Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the username/password for requests #21

Merged
merged 2 commits into from Nov 9, 2023
Merged

Conversation

rcarver
Copy link
Contributor

@rcarver rcarver commented Nov 8, 2023

This fixes that the username and password parameters weren't passed along to the request.

An instance of Elastic Search with basic auth enabled can now be used with this library.

Copy link
Member

@0xTim 0xTim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes this might actually help! Thanks

@0xTim 0xTim merged commit 90be7e2 into brokenhandsio:main Nov 9, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants