-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Swift 5.5 and async/await #21
Conversation
@ptoffy can you merge in the latest changes from |
@0xTim I think the tests are failing because the installed version of swift on CI is 5.2 and 5.4 |
@ptoffy yeah, now the CI is in your fork you should be able to change |
Codecov Report
@@ Coverage Diff @@
## main #21 +/- ##
===========================================
+ Coverage 83.33% 96.61% +13.27%
===========================================
Files 2 2
Lines 66 59 -7
===========================================
+ Hits 55 57 +2
+ Misses 11 2 -9
Continue to review full report at Codecov.
|
@0xTim have you had any time to review this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great thanks! There's just a couple of missing tests and we're good to go!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Updated
swift-tools-version
to 5.5 and addedasync/await
support to the project.Removed
EventLoopFuture
tests as they are redundant when usingasync/await
.