Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Swift 5.5 and async/await #21

Merged
merged 6 commits into from
Dec 20, 2021
Merged

Conversation

ptoffy
Copy link
Member

@ptoffy ptoffy commented Dec 2, 2021

Updated swift-tools-version to 5.5 and added async/await support to the project.
Removed EventLoopFuture tests as they are redundant when using async/await.

@0xTim
Copy link
Member

0xTim commented Dec 8, 2021

@ptoffy can you merge in the latest changes from main - that should trigger CI

@ptoffy
Copy link
Member Author

ptoffy commented Dec 9, 2021

@0xTim I think the tests are failing because the installed version of swift on CI is 5.2 and 5.4

@0xTim
Copy link
Member

0xTim commented Dec 9, 2021

@ptoffy yeah, now the CI is in your fork you should be able to change swift:5.2-xenial to swift:5.5 etc

@codecov
Copy link

codecov bot commented Dec 9, 2021

Codecov Report

Merging #21 (6b06aff) into main (f8d4517) will increase coverage by 13.27%.
The diff coverage is 97.43%.

Impacted file tree graph

@@             Coverage Diff             @@
##             main      #21       +/-   ##
===========================================
+ Coverage   83.33%   96.61%   +13.27%     
===========================================
  Files           2        2               
  Lines          66       59        -7     
===========================================
+ Hits           55       57        +2     
+ Misses         11        2        -9     
Impacted Files Coverage Δ
...rces/LeafErrorMiddleware/LeafErrorMiddleware.swift 95.91% <97.29%> (-1.91%) ⬇️
...ddleware/LeafErrorMiddlewareDefaultGenerator.swift 100.00% <100.00%> (+50.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8d4517...6b06aff. Read the comment docs.

@ptoffy
Copy link
Member Author

ptoffy commented Dec 18, 2021

@0xTim have you had any time to review this?

Copy link
Member

@0xTim 0xTim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great thanks! There's just a couple of missing tests and we're good to go!

Copy link
Member

@0xTim 0xTim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@0xTim 0xTim merged commit bd4d565 into brokenhandsio:main Dec 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants