Migrate to Vapor 4 #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Closed
0xTim
approved these changes
Feb 13, 2023
| @@ -52,15 +52,15 @@ struct PasswordTokenHandler { | |||
| } | |||
|
|
|||
| guard let userID = userManager.authenticateUser(username: username, password: password) else { | |||
| log.warning("LOGIN WARNING: Invalid login attempt for user \(username)") | |||
| logger.warning("LOGIN WARNING: Invalid login attempt for user \(username)") | |||
There was a problem hiding this comment.
Let's make the log level configurable
|
Going to merge this now, we can iterate on it going forward |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates the entire library to Vapor 4. There is an example project over here.
Note: There is more work to do:
OAuthUseris a very opinionatedclass. We should consider changing this to a generic type/ protocol.