Closing Incognito Tab closes New Tabs under Normal Tabs and redirects to 1st tab #1030

pixincreate · 2021-03-28T06:18:10Z

Bromite version

Version: 93.0.4577.83
Arch: arm64
Android version: 10
Device model: Nokia 6.1 Plus (DRG)

Flags

These are the flags changed under chrome://flags:

Enable IPv6 Probing (Enabled)
Parallel Downloading (Enabled)
Download auto-resumption native (Enabled)
tab engagement metrics (Disabled)
Support for HTTPSSVC records in DNS (Disabled)

Is this bug about the SystemWebView?

No

Is the bug reproducible with latest version?

Yes

Can the bug be reproduced with corresponding Chromium version?

No

Allow ads for the site; is the bug caused by the adblocker?

No

Is the bug a crash?

No

Describe the bug

I've some tabs opened for reference. Along with that I usually keep a newtab in the forefront of other previous tabs.
For random things, I use incognito tabs.
When I close them, once my research is done, it brings me to the 1st normal tab closing the newtab which'd be in the forefront.
I literally feel it annoying as I'm supposed to open the newtab again every time I close an incognito tab, which doesn't happen in chromium.

Steps to reproduce the bug

Steps to reproduce the bug:

Have some tabs open under normal tabs
Have NewTab opened at last.
Open an incognito tab and do your research.
Close the incognito tab my any means. Either close from the notification bar/clear the RAM, or systematically close the incognito tab by clicking tab and x button(this doesn't close the newtab but highlights the first tab).

Expected behavior

It should not touch the newtab i.e., opened.
When I close the incognito tab, you should be redirected to the last tab atleast, not the beginning of the tab(1st tab).

Recording

Incognito recording has been turned black by default.
Here's the recording.(Initially, it showed no bug like as I said before, but on doing the same for the 2nd time, it happened.)

LINK:
https://user-images.githubusercontent.com/69745008/112744179-5bfe9780-8fbb-11eb-9519-5e94c6988081.mp4
(Above link didn't seem to work, so, compressed the video into a zip uploaded below.)
Bug in Bromite.zip

The text was updated successfully, but these errors were encountered:

uazo · 2021-04-10T08:04:12Z

do you have the new homepage option enabled with "custom web address" to nothing?

with those settings I detect this crash, but maybe it has nothing to do with it.

04-10 07:58:06.886  9412  9412 W System.err: java.lang.AssertionError: Homepage should be disabled for a null URL
04-10 07:58:06.886  9412  9412 W System.err:    at org.chromium.chrome.browser.metrics.LaunchMetrics.recordHomePageLaunchMetrics(LaunchMetrics.java:106)
04-10 07:58:06.886  9412  9412 W System.err:    at org.chromium.chrome.browser.init.ProcessInitializationHandler$2$1.run(ProcessInitializationHandler.java:303)
04-10 07:58:06.886  9412  9412 W System.err:    at android.os.MessageQueue.nativePollOnce(Native Method)
04-10 07:58:06.886  9412  9412 W System.err:    at android.os.MessageQueue.next(MessageQueue.java:326)
04-10 07:58:06.886  9412  9412 W System.err:    at android.os.Looper.loop(Looper.java:160)
04-10 07:58:06.886  9412  9412 W System.err:    at android.app.ActivityThread.main(ActivityThread.java:6669)
04-10 07:58:06.886  9412  9412 W System.err:    at java.lang.reflect.Method.invoke(Native Method)
04-10 07:58:06.886  9412  9412 W System.err:    at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:493)
04-10 07:58:06.886  9412  9412 W System.err:    at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:858)
04-10 07:58:06.887  9412  9468 I cr_ProcessInitHandler: Attempting to upload 1 accumulated crash dumps.
04-10 07:58:06.887  9412  9468 I cr_MinidumpJobService: Scheduling upload of all pending minidumps.
04-10 07:58:06.890  9412  9462 I cr_LogcatExtraction: Trying to extract logcat for minidump 6fc23d49-8f39-41fe-8307-be31e20aaa42.dmp9242.
04-10 07:58:06.898  9412  9468 E cr_PackageMetrics: Could not parse UUID 1001-1409
04-10 07:58:06.898  9412  9468 E cr_PackageMetrics: java.lang.IllegalArgumentException: Invalid UUID string: 1001-1409
04-10 07:58:06.898  9412  9468 E cr_PackageMetrics:     at java.util.UUID.fromString(UUID.java:194)
04-10 07:58:06.898  9412  9468 E cr_PackageMetrics:     at org.chromium.chrome.browser.metrics.PackageMetrics.getPackageStatsForAndroidO(PackageMetrics.java:55)
04-10 07:58:06.898  9412  9468 E cr_PackageMetrics:     at org.chromium.chrome.browser.metrics.PackageMetrics.recordPackageStats(PackageMetrics.java:84)
04-10 07:58:06.898  9412  9468 E cr_PackageMetrics:     at org.chromium.chrome.browser.init.ProcessInitializationHandler$11.doInBackground(ProcessInitializationHandler.java:473)
04-10 07:58:06.898  9412  9468 E cr_PackageMetrics:     at org.chromium.chrome.browser.init.ProcessInitializationHandler$11.doInBackground(ProcessInitializationHandler.java:430)
04-10 07:58:06.898  9412  9468 E cr_PackageMetrics:     at org.chromium.base.task.AsyncTask$1.call(AsyncTask.java:106)
04-10 07:58:06.898  9412  9468 E cr_PackageMetrics:     at java.util.concurrent.FutureTask.run(FutureTask.java:266)
04-10 07:58:06.898  9412  9468 E cr_PackageMetrics:     at org.chromium.base.task.AsyncTask$NamedFutureTask.run(AsyncTask.java:404)
04-10 07:58:06.910  9412  9412 F chromium: [FATAL:jni_android.cc(306)] Please include Java exception stack in crash report

pixincreate · 2021-04-10T08:27:26Z

No. Homepage was turned off so far for me.
However, I checked the issue by turning on, still same results which is described in the bug report*..

uazo · 2021-04-10T09:22:11Z

@csagan5 in the situation described by the user
under memory pressure with

adb shell am send-trim-memory org.chromium.chrome.stable COMPLETE

I had another crash:

04-10 09:00:35.338 13146 13146 E AndroidRuntime: java.lang.AssertionError: Destroy called before removed from window
04-10 09:00:35.338 13146 13146 E AndroidRuntime: 	at org.chromium.chrome.browser.ntp.IncognitoNewTabPage.destroy(IncognitoNewTabPage.java:151)
04-10 09:00:35.338 13146 13146 E AndroidRuntime: 	at org.chromium.chrome.browser.ui.native_page.FrozenNativePage.freeze(FrozenNativePage.java:32)
04-10 09:00:35.338 13146 13146 E AndroidRuntime: 	at org.chromium.chrome.browser.tab.TabImpl.freezeNativePage(TabImpl.java:429)
04-10 09:00:35.338 13146 13146 E AndroidRuntime: 	at org.chromium.chrome.browser.native_page.NativePageAssassin.freeze(NativePageAssassin.java:87)
04-10 09:00:35.338 13146 13146 E AndroidRuntime: 	at org.chromium.chrome.browser.native_page.NativePageAssassin.freezeAllHiddenPages(NativePageAssassin.java:81)
04-10 09:00:35.338 13146 13146 E AndroidRuntime: 	at org.chromium.chrome.browser.ChromeTabbedActivity.onTrimMemory(ChromeTabbedActivity.java:2322)
04-10 09:00:35.338 13146 13146 E AndroidRuntime: 	at android.app.ActivityThread.handleTrimMemory(ActivityThread.java:5431)
04-10 09:00:35.338 13146 13146 E AndroidRuntime: 	at android.app.ActivityThread.access$900(ActivityThread.java:199)
04-10 09:00:35.338 13146 13146 E AndroidRuntime: 	at android.app.ActivityThread$ApplicationThread.lambda$scheduleTrimMemory$0(ActivityThread.java:1419)
04-10 09:00:35.338 13146 13146 E AndroidRuntime: 	at android.app.-$$Lambda$ActivityThread$ApplicationThread$tUGFX7CUhzB4Pg5wFd5yeqOnu38.accept(Unknown Source:8)
04-10 09:00:35.338 13146 13146 E AndroidRuntime: 	at com.android.internal.util.function.pooled.PooledLambdaImpl.doInvoke(PooledLambdaImpl.java:258)
04-10 09:00:35.338 13146 13146 E AndroidRuntime: 	at com.android.internal.util.function.pooled.PooledLambdaImpl.invoke(PooledLambdaImpl.java:182)
04-10 09:00:35.338 13146 13146 E AndroidRuntime: 	at com.android.internal.util.function.pooled.OmniFunction.run(OmniFunction.java:77)
04-10 09:00:35.338 13146 13146 E AndroidRuntime: 	at android.view.Choreographer$CallbackRecord.run(Choreographer.java:949)
04-10 09:00:35.338 13146 13146 E AndroidRuntime: 	at android.view.Choreographer.doCallbacks(Choreographer.java:761)
04-10 09:00:35.338 13146 13146 E AndroidRuntime: 	at android.view.Choreographer.doFrame(Choreographer.java:698)
04-10 09:00:35.338 13146 13146 E AndroidRuntime: 	at android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:935)
04-10 09:00:35.338 13146 13146 E AndroidRuntime: 	at android.os.Handler.handleCallback(Handler.java:873)
04-10 09:00:35.338 13146 13146 E AndroidRuntime: 	at android.os.Handler.dispatchMessage(Handler.java:99)
04-10 09:00:35.338 13146 13146 E AndroidRuntime: 	at android.os.Looper.loop(Looper.java:193)
04-10 09:00:35.338 13146 13146 E AndroidRuntime: 	at android.app.ActivityThread.main(ActivityThread.java:6669)
04-10 09:00:35.338 13146 13146 E AndroidRuntime: 	at java.lang.reflect.Method.invoke(Native Method)
04-10 09:00:35.338 13146 13146 E AndroidRuntime: 	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:493)
04-10 09:00:35.338 13146 13146 E AndroidRuntime: 	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:858)

maybe it has nothing to do with it and maybe chromium also behaves like this

csagan5 · 2021-06-27T15:15:13Z

in the situation described by the user
under memory pressure with

adb shell am send-trim-memory org.chromium.chrome.stable COMPLETE

I had another crash:

@uazo that's not Bromite.

@pixincreate can you reproduce this with latest version? I cannot reproduce either problems.

uazo · 2021-06-27T16:41:52Z

adb shell am send-trim-memory org.chromium.chrome.stable COMPLETE

you mean for org.chromium.chrome.stable ?
yes it was bromite, my debug version.

I cannot reproduce either problems.

perfect

pixincreate · 2021-06-29T03:36:30Z

It happens with me sometimes, but not always.
When?

Open incognito tab by long pressing the Bromite icon>> Incognito.
Do your search.
Close incognito browsing from the notification bar.
You'll be taken to the first normal tab and not the last, if you've an empty tab opened, that tab will be closed.

csagan5 · 2021-09-26T09:53:18Z

@pixincreate can you reproduce this with latest version v93?

@uazo do those other 2 crashes you found still happen? If yes we need a separate issue to fix them.

pixincreate · 2021-09-26T10:18:39Z

I tried to reproduce the issue again, and this time, the same happened with only one scenario.

Long press on the Bromite icon and create a homescreen shortcut for Incognito Mode.
Make sure you've a newtab opened under the normal tabs.
Make a search under Incognito.
Close it(I closed from the notification menu).
On the normal tabs, now, the newtab is lost and you're redirected to the first tab., Which IMO should not happen.

This doesn't happen when Incognito is opened within the app or by clicking on the Incognito by long pressing the Bromite icon. May be, it's fixed for such cases.

pixincreate · 2021-09-26T10:22:57Z

What!? The bug report format completely obeyed to the legacy Template.
@csagan5, kindly take a look.

pixincreate · 2021-10-22T03:19:21Z

Hey, latest pushed update started to highlight this issue more.

Open an external link
do your work
close it from the notification bar
and boom! You're in the first tab of your browser with top most empty tab removed(say 5th tab in my case).

Edit: AFAIK, this existed for a long time now... I keep required tabs open and an empty tab at the top for convenience.

csagan5 · 2021-10-23T10:38:51Z

@uazo is this a new bug?

uazo · 2021-10-23T12:49:00Z

is this a new bug?

no, I think he is telling us that it is now easily reproducible, I'll watch

uazo · 2021-10-26T10:06:32Z

I confirm.

Steps:

make sure you have multiple tabs open and the last tab as your homepage
close bromite with full exit
open a external link in incognito
close from notification
reopen bromite, the last tab has been closed and reopens on the first

I had seen in the chromium code that it was intended, the list of open tabs on the homepage is not recorded in the file of the tabs to reopen.

maybe I can fix it, so I see if it is also possible to keep the list of tabs between sessions in always incognito.

csagan5 · 2021-11-07T10:34:57Z

Fixed in 95.0.4638.78.

kokukyocho added bug needs-triage labels Mar 28, 2021

uazo mentioned this issue Apr 29, 2021

enable crash reporting ui, allow save report to primary download folder #1105

Merged

pixincreate changed the title ~~Closing Incognito Tab closes New Tabs under Normal Tabs~~ Closing Incognito Tab closes New Tabs under Normal Tabs and redirects to 1st tab Sep 26, 2021

This comment has been minimized.

Sign in to view

kokukyocho closed this as completed Sep 26, 2021

kokukyocho added the missing-issue-template This issue was not created with the issue template label Sep 26, 2021

csagan5 reopened this Sep 26, 2021

uazo mentioned this issue Oct 27, 2021

Keep empty tabs between sessions #1515

Merged

csagan5 closed this as completed in #1515 Nov 4, 2021

csagan5 reopened this Nov 5, 2021

csagan5 closed this as completed Nov 7, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Closing Incognito Tab closes New Tabs under Normal Tabs and redirects to 1st tab #1030

Closing Incognito Tab closes New Tabs under Normal Tabs and redirects to 1st tab #1030

pixincreate commented Mar 28, 2021 •

edited by csagan5

uazo commented Apr 10, 2021

pixincreate commented Apr 10, 2021 •

edited

uazo commented Apr 10, 2021

csagan5 commented Jun 27, 2021

uazo commented Jun 27, 2021

pixincreate commented Jun 29, 2021

csagan5 commented Sep 26, 2021

pixincreate commented Sep 26, 2021

This comment has been minimized.

pixincreate commented Sep 26, 2021 •

edited

pixincreate commented Oct 22, 2021 •

edited

csagan5 commented Oct 23, 2021

uazo commented Oct 23, 2021

uazo commented Oct 26, 2021

csagan5 commented Nov 7, 2021

Closing Incognito Tab closes New Tabs under Normal Tabs and redirects to 1st tab #1030

Closing Incognito Tab closes New Tabs under Normal Tabs and redirects to 1st tab #1030

Comments

pixincreate commented Mar 28, 2021 • edited by csagan5

Bromite version

Flags

Is this bug about the SystemWebView?

Is the bug reproducible with latest version?

Can the bug be reproduced with corresponding Chromium version?

Allow ads for the site; is the bug caused by the adblocker?

Is the bug a crash?

Describe the bug

Steps to reproduce the bug

Expected behavior

Recording

uazo commented Apr 10, 2021

pixincreate commented Apr 10, 2021 • edited

uazo commented Apr 10, 2021

csagan5 commented Jun 27, 2021

uazo commented Jun 27, 2021

pixincreate commented Jun 29, 2021

csagan5 commented Sep 26, 2021

pixincreate commented Sep 26, 2021

This comment has been minimized.

pixincreate commented Sep 26, 2021 • edited

pixincreate commented Oct 22, 2021 • edited

csagan5 commented Oct 23, 2021

uazo commented Oct 23, 2021

uazo commented Oct 26, 2021

csagan5 commented Nov 7, 2021

pixincreate commented Mar 28, 2021 •

edited by csagan5

pixincreate commented Apr 10, 2021 •

edited

pixincreate commented Sep 26, 2021 •

edited

pixincreate commented Oct 22, 2021 •

edited