Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Malfunctioning sticky desktop mode #2179

Closed
4 tasks done
rdj0im opened this issue Jul 7, 2022 · 5 comments
Closed
4 tasks done

Malfunctioning sticky desktop mode #2179

rdj0im opened this issue Jul 7, 2022 · 5 comments
Assignees

Comments

@rdj0im
Copy link

rdj0im commented Jul 7, 2022

Preliminary checklist

  • I have read the README.
  • I have searched the existing issues for my problem. This is a new ticket, NOT a duplicate or related to another open issue.
  • I have read the FAQs.
  • I have updated Bromite to the latest version. The bug is reproducible on this latest version.

Can the bug be reproduced with corresponding Chromium version?

No

Bromite version

102.0.5005.96

Device architecture

arm64-v8a

Android version

11

Device model

Redmi 9 M2006C3MII

Changed flags

enable-tab-groups

Is this bug about the SystemWebView?

No

Is this bug happening in an incognito tab?

Yes

Is this bug caused by the adblocker?

No

Is this bug a crash?

No

Describe the bug

Desktop mode doesn't stick and is disabled with opening of each new tab. When "Current behaviour for desktop mode toggle in hamburger menu" is set to "Applies to all tabs" (sticky mode) and desktop mode is enabled, opening a new tab causes all tabs (including current tab) to be switched back to normal mode, instead of the new tabs being opened in desktop mode. Also Desktop mode doesn't persist between sessions like it used to.

Steps to reproduce the bug

  1. Set "Current behaviour for desktop mode toggle in hamburger menu" in "Customize User Agent" setting to Applies to all tabs" (sticky mode).
  2. Open a tab.
  3. Enable Desktop mode in hamburger menu.
  4. Open any site in another tab.

Expected behavior

New tabs would be opened in Desktop mode and ones already in Desktop mode would remain so until I explicitly turn off desktop mode in the hamburger menu.

Screenshots

No response

@uazo
Copy link
Collaborator

uazo commented Jul 8, 2022

thanks, I confirm the bug. I will check

@csagan5
Copy link
Contributor

csagan5 commented Jul 17, 2022

Fixed in 103.0.5060.126.

@csagan5 csagan5 closed this as completed Jul 17, 2022
@uazo
Copy link
Collaborator

uazo commented Jul 19, 2022

Maybe the correct user agent string is not being sent in the former case or something?

@rdj0im Yes you are right. I focused on the viewport and not the network layer, I'll check.

@csagan5
Copy link
Contributor

csagan5 commented Jul 25, 2022

@uazo please re-open if bug is not yet fixed (or we need a new issue).

@uazo
Copy link
Collaborator

uazo commented Jul 25, 2022

please re-open if bug is not yet fixed

same for @rdj0im

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants