Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sharing hub: use visible URL instead of canonical URL #2204

Closed
3 tasks done
Devocub opened this issue Jul 19, 2022 · 3 comments
Closed
3 tasks done

Sharing hub: use visible URL instead of canonical URL #2204

Devocub opened this issue Jul 19, 2022 · 3 comments
Assignees

Comments

@Devocub
Copy link

Devocub commented Jul 19, 2022

Preliminary checklist

  • I have read the README
  • I have read the FAQs.
  • I have searched existing issues for my feature request. This is a new issue (NOT a duplicate) and is not related to another issue.

Is your feature request related to privacy?

Yes

Is there a patch available for this feature somewhere?

no

Describe the solution you would like

Example: go to old.reddit.com and share link using Share feature in 3 dots menu. You'll see shared link is www.reddit.com, I guess it uses html tag link rel="canonical". I don't know if it can be completely different link. I suggest you to change behavior to use actual link from browser url field which is old.reddit.com

Describe alternatives you have considered

no

@Devocub
Copy link
Author

Devocub commented Jul 28, 2022

Found another site which is broken
https://f-droid.org/en/packages/org.alberto97.ouilookup/
sharing this^ actualle shares <link rel="canonical" href="https://f-droid.org/">
just wtf

@csagan5
Copy link
Contributor

csagan5 commented Aug 8, 2022

It is not broken, it has always worked like that by design in Chromium; I will change it in Bromite to use the visible URL, although there are some corner cases where that is not desired.

@csagan5 csagan5 self-assigned this Aug 8, 2022
@csagan5 csagan5 changed the title Share link feature fix Sharing hub: use visible URL instead of canonical URL Aug 8, 2022
@csagan5
Copy link
Contributor

csagan5 commented Aug 14, 2022

Fixed in 104.0.5112.91.

@csagan5 csagan5 closed this as completed Aug 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants