Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Android 9’s AutoFill functionality in Browser #230

Closed
Moxville opened this issue Jan 22, 2019 · 5 comments
Closed

Support for Android 9’s AutoFill functionality in Browser #230

Moxville opened this issue Jan 22, 2019 · 5 comments
Labels

Comments

@Moxville
Copy link

Is your feature request related to privacy?
No

Is there a patch available for this feature somewhere?
Not Applicable

Describe the solution you'd like
Add support for password managers to Autofill in browser (Android P)
News Source:
https://blog.dashlane.com/android-p-autofill/
https://blog.lastpass.com/2018/10/android-pie-autofill-save-time-autofill-lastpass-android.html/
https://www.xda-developers.com/android-p-autofill-browsers/
https://www.androidauthority.com/autofill-automatically-work-browsers-android-p-844555/

Describe alternatives you've considered
Not Applicable

@csagan5
Copy link
Contributor

csagan5 commented Jan 22, 2019

@Moxville does this functionality use cloud integrations? If yes, then it's not supported.

I cannot clearly tell whether it's available or not, my best guess is that this uses some cloud API and it is already disabled in Bromite.

@javiersantos
Copy link

javiersantos commented Feb 11, 2019

I don't think this functionality depends on a cloud service. It's already sopported in other browsers like Firefox or Edge on Android.

I think it may be related to Bromite not exposing the full URL when using third party integrations (for example, autocomplete logins with password manager keyboards).

Anyway, I think it would be interesting to keep working on this.

#enable-android-autofill-accessibility

@javiersantos
Copy link

javiersantos commented Feb 11, 2019

Response from Enpass:

"The problem is with the browser which is not revealing the URL being browsed and instead of that passing-on its own package name to Enpass. Actually, the behavior should be like Chrome which passes-on the exact URL to Enpass to save for future autofill operations. For better autofilling experience we recommend to use Chrome, Firefox-Focus or Edge works well with autofill by Android framework as well as through Notifications."

https://discussion.enpass.io/index.php?/topic/5563-wrong-autofill-information-gets-added-automatically/&do=findComment&comment=12006

@csagan5 could you take a look at it? Thanks.

@csagan5
Copy link
Contributor

csagan5 commented Feb 11, 2019

@javiersantos the only functionality disabled in Bromite is the interaction with Google APIs (it would not work regardless because a valid service account would be needed): https://github.com/bromite/bromite/blob/abfa65cd1751916188bc458bd7327ae46e367cfa/build/patches/autofill-disable-autofill-download-manager.patch

For the rest of the functionality you can enable it from the settings menu and test (I assume you have already enabled it before testing?).

"The problem is with the browser which is not revealing the URL being browsed and instead of that passing-on its own package name to Enpass. Actually, the behavior should be like Chrome which passes-on the exact URL to Enpass to save for future autofill operations. For better autofilling experience we recommend to use Chrome, Firefox-Focus or Edge works well with autofill by Android framework as well as through Notifications."

When submitting a new issue (not the case when commenting on an existing closed issue like this one) there is a section asking to test with the corresponding Chromium version. This has obviously not been done here, because otherwise you/the Enpass developer could verify that Chromium shows exactly the same behaviour.

@csagan5
Copy link
Contributor

csagan5 commented Oct 24, 2021

This has been resolved in #547; the short version is that Chromium by default uses GCM (Play Store binaries version) and in the past used the Android native version, like other browsers do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants