Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance issue with SystemWebview after update #362

Closed
M86xKC opened this issue Aug 29, 2019 · 15 comments
Closed

Performance issue with SystemWebview after update #362

M86xKC opened this issue Aug 29, 2019 · 15 comments
Labels

Comments

@M86xKC
Copy link

M86xKC commented Aug 29, 2019

Bromite version

Version: > v72.0.3626.119
Arch: arm64
Android version: 9.0
Device model: Samsung Galaxy J7 Pro 2016

Is the bug reproducible with latest version?

Yes.

Can the bug be reproduced with corresponding Chromium version?

I think the performance issue is related to the additions that were in the Bromite v72.0.3626.120 release.

  • add support for resource type in adblock engine (fixes Add support of advanced blocking rules #115)
  • adblock engine speed optimizations
  • use adblock engine also in SystemWebView
  • add back uBlock Origin and EasyList filters
  • added Fanboy's Annoyance List

Is the bug a crash?

No

Describe the bug

Recently I updated my SystemWebview from an older version to the most recent one. And immediately I notice a huge performance issue (lag) in all applications dependent on Webview. After testing different versions I found the issues appeared starting from Bromite v72.0.3626.120 till the most recent one.

I think It is more obvious to noticed on a lower-end (mid-range device), because of the low processing power.

To Reproduce

  1. Update to any version > v72.0.3626.119
  2. the lag happens when loading the page & scrolling

Expected behavior

Normal behavior (no lag)

Screenshots

I wanted to record the screen, but I found it was not clear from the video because of the low quality of the video recording 10fps ¯_(ツ)_/¯

@csagan5
Copy link
Contributor

csagan5 commented Aug 30, 2019

You have to test with the Chromium WebView, this might be related to #353 which happens also without adblock.

@M86xKC
Copy link
Author

M86xKC commented Aug 31, 2019

I thing this is not related to the other issue. I have no problem in the regular Bromite app, but rather in apps that depend on SystemWebView.

I have tried this SystemWebView and didn't have any problems (lag).

@Adrymate9
Copy link

hello, the version I try to use is v76.0.3809.129. ARM64. phone Huawei mate 9 with android 8.0. It really works very badly, freezing at all times when scrolling through the web pages.

I tried what they follow, using v72.0.3626.120I had no luck is still missing in the same way.

Hopefully they can fix it in the next update. I love this browser.

@M86xKC
Copy link
Author

M86xKC commented Sep 1, 2019

@Adrymate9

Try v72.0.3626.119 and see if the issue still persists ?

And btw how did you change the systemwebview on unlocked bootloader, just curious 😉

@Adrymate9
Copy link

Adrymate9 commented Sep 1, 2019

@M86xKC Now I am going to try this version that I suggest and come back to comment on the experience

Regarding systemwebview, I'm really new to this and I don't understand what you mean or how I should proceed with this. I would appreciate your help on this topic.

@Adrymate9
Copy link

Adrymate9 commented Sep 1, 2019

@M86xKC Effectively in version 72.0.3626.129 I also have the same problem.

@csagan5
Copy link
Contributor

csagan5 commented Sep 5, 2019

I have tried this SystemWebView and didn't have any problems (lag).

You need to test with the Chromium SystemWebview provided by this project.

@Adrymate9
Copy link

@csagan5 I have installed systemwebview x64 that proposes bromite. But once downloaded it does not appear in the corresponding section in the developer settings of my phone.

I don't know how to make it work above default systemwebview Help.

@M86xKC
Copy link
Author

M86xKC commented Sep 5, 2019

You need to test with the Chromium SystemWebview provided by this project.

How can I get this ?

@csagan5
Copy link
Contributor

csagan5 commented Sep 5, 2019

How can I get this ?

https://www.bromite.org/chromium for latest version

@M86xKC
Copy link
Author

M86xKC commented Sep 5, 2019

No issues what so ever.
I tried the latest version btw (76.0.3809.129)

@Adrymate9

This comment has been minimized.

@M86xKC
Copy link
Author

M86xKC commented Sep 5, 2019

@Adrymate9

This comment has been minimized.

@csagan5
Copy link
Contributor

csagan5 commented Sep 5, 2019

No issues what so ever.
I tried the latest version btw (76.0.3809.129)

We can conclude it's adblock-related; the issue might change radically with the next release (v77) of Bromite SystemWebView as the NetworkService must be used; you will have to test with that one once it's released.

However, even if the issue is acknowledged, we cannot fix it if it's simply caused by the AdBlocker.

@csagan5 csagan5 added adblock and removed invalid labels Sep 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants