Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable PartitionExpectCTStateByNetworkIsolationKey too #985

Closed
thestinger opened this issue Mar 8, 2021 · 4 comments
Closed

enable PartitionExpectCTStateByNetworkIsolationKey too #985

thestinger opened this issue Mar 8, 2021 · 4 comments

Comments

@thestinger
Copy link

thestinger commented Mar 8, 2021 •
edited
Loading

This feature is included in the PartitionConnectionsByNetworkIsolationKey field trial too. There are 7 features enabled there on top of the baseline SplitCacheByNetworkIsolationKey. Bromite has 5/7 of these enabled right now.
@thestinger
Copy link
Author

You might as well also enable PartitionNelAndReportingByNetworkIsolationKey too even if it's not expected to do anything for Bromite. The PartitionDomainReliabilityByNetworkIsolationKey feature is already enabled by default, although domain reliability is similarly disabled.

@csagan5
Copy link
Contributor

csagan5 commented Mar 8, 2021

Related #836

Are these all enabled in Vanadium too?

@thestinger
Copy link
Author

They're all going to be enabled now to do the same thing as that field trial.

@csagan5
Copy link
Contributor

csagan5 commented Mar 8, 2021

Fixed in 89.0.4389.78.

@csagan5 csagan5 closed this as completed Mar 8, 2021
This was referenced Mar 20, 2021
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@thestinger @csagan5