-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AspNet.Core support #5
Comments
@LeonidEfremov - Sorry I never got notified of the issue creation. I am currently in the middle of creating a package for AspNet Core right now. I'll give you a shout when I have something. Currently hitting an issue with nuget to package the projects up at the moment. |
@bronumski, thank you =) |
Hi, @bronumski! Any progress on this issue? We really need this update =) |
@LeonidEfremov - Just pushed some changes. I have not tested the packages yet. Appveyor picked up the change and published them before I could configure it to push out a beta release. I'll test it later and if it doesn't work I will remove the package. |
@LeonidEfremov - I backed out the package and pushed up a beta version
|
Wow, great! Will be test it next 2-3 days, and report to you. |
Can you change signature for IServiceCollection AddHealthNet(Action<HealthNetConfiguration> setupAction) |
We still need to register each ISystemChecker manualy: services.AddTransient<ISystemChecker, CustomChecker>(); think better implementation will be AutoMapper-style: services.AddAutoMapper(GetType().Assembly) |
Everything working well =) Just one warning
|
Yes I got the warning too. I need to change how it is packaged. This would be a good one.
I'm not sure about this though:
Not that I don't like auto wire up, I do. I want to get a better idea of how teams are using core IoC and if they are using anything on top such as Windsor, AutoFac etc which would already do the above. So not dismissing it, but I want to look around at other projects and see what they are doing. |
What are your thoughts on this instead of the above.
I would be interested in seeing a use case for the Action approach I am going to push the above if you want to try it out. |
Will test it today |
So, version
while application starting. Also this interface looks not well: IServiceCollection AddHealthNet<THealthNetConfig>(this IServiceCollection service) think better is IServiceCollection AddHealthNet(Action<HealthNetConfiguration> setupAction) |
Ok I will check it out. I have not had time to fully test the package, just the run the intregration tests. Can you do an example of how you would expect a usage of your above method might look? |
The version error that you are getting is because of the way I generate the nuspec files and they don't know about the dependency version suffix, they only know the version number. Therefore the dependency version is put in as To get around this make sure you install both packages:
By default .net core projects have
This will all be sorted when it is published as a non beta package. Right now I don't have time to change the way the packages are built. I can confirm that I have done this to a new project and it works as expected. Just waiting on your feedback about the extension methods. |
Thx, i start application and everything is working well.
app.UseHealthNet();
services
.AddTransient<ISystemChecker, DefaultChecker>()
.AddHealthNet(HeathConfiguration);
protected virtual void HeathConfiguration(IHealthNetConfiguration configuration)
{
configuration.Path = "health";
configuration.DefaultSystemCheckTimeout= TimeSpan.FromSeconds(10);
} |
So in 3 you don't want to use a custom configuration object. What you lose here is that, if you use a custom configuration object the service will:
This means your add service in step 2. would just be: services
.AddHealthNet<CustomHealthcheckConfig>(); Perhaps we can have an override of that allows the above but currently |
This way is ok to, but i prefer Action instead of generic. |
When do you plan to release? |
I was considering switching to async calls so that we could have it async all the way from the controller / module but I'll leave that for another time. I'll try and push it shortly. |
ping =) |
Merged and released. |
Any plans for migration?
The text was updated successfully, but these errors were encountered: