Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't set systemVersion for output json #4

Closed
LeonidEfremov opened this issue May 10, 2017 · 4 comments
Closed

Can't set systemVersion for output json #4

LeonidEfremov opened this issue May 10, 2017 · 4 comments

Comments

@LeonidEfremov
Copy link

LeonidEfremov commented May 10, 2017

No ability to manage value of systemVersion parameter. Also, will be great to display this systemVersion on Dashboard.

@bronumski
Copy link
Owner

@LeonidEfremov - Again sorry I didn't get a notification of issues being created.

Could you give a bit more detail as to what your expectations are?

@bronumski
Copy link
Owner

Actually I think I know what you are after. By default the systemVersion is pulled from the assembly file version using the VersionProvider however if you want to do something else you can implement the IVersionProvider yourself and pull the version from elsewhere but in order to do this you need to create the HealthCheckService yourself. The WebApi/Nancy and Owin components don't allow you to do this. Maybe this is something I can improve on.

Let me know if this would address your issue?

@bronumski
Copy link
Owner

@LeonidEfremov - Did you ever get this working? With the new aspnet core package you asked for (#5) injecting in your own VersionProvider is easier.

I will update the docs later.

@bronumski bronumski reopened this Mar 15, 2018
@bronumski
Copy link
Owner

Allowing the version provider to be injected to the various platforms has been addressed by doing #5. Docs have been updated too. In terms of the dashboard I wasn't expecting anyone to actually use it directly but just show it as a proof of concept. Maybe I will take a look at including the version number later but closing this for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants