Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mime.getType('mp4') gives me 'application/mp4' rather than 'video/mp4' #297

Closed
1 task
cloydlau opened this issue Dec 17, 2023 · 1 comment
Closed
1 task

Comments

@cloydlau
Copy link

cloydlau commented Dec 17, 2023

If you have an issue with a specific extension or type

Locate the definition for your extension/type in the db.json file in the mime-db project. Does it look right?

  • No. File a mime-db issue.
  • [✓] Yes: Go ahead and submit your issue/PR here and I'll look into it.

Hello,
mime.getType('mp4') gives me 'application/mp4' rather than 'video/mp4', I did find both of them in https://github.com/jshttp/mime-db/blob/master/db.json, but I think the MIME type of mp4 should be video/mp4 in most cases. Or do we need a mime.getAllTypes to solve this?

@cloydlau cloydlau changed the title mime.getType('mp4') gives me application/mp4 rather than video/mp4 mime.getType('mp4') gives me 'application/mp4' rather than 'video/mp4' Dec 17, 2023
broofa added a commit that referenced this issue Dec 17, 2023
@broofa
Copy link
Owner

broofa commented Dec 17, 2023

@cloydlau Good catch, and thanks for the report. If you update to mime@latest, this should be fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants