Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidy up execution timings logic #389

Merged
merged 4 commits into from
Oct 5, 2023
Merged

Conversation

glsdown
Copy link
Contributor

@glsdown glsdown commented Sep 29, 2023

Overview

In #386 there was some great work to fix issues in model execution timings, this applies the same fixes to the other execution models.

Update type - breaking / non-breaking

  • Minor bug fix
  • Documentation improvements
  • Quality of Life improvements
  • New features (non-breaking change)
  • New features (breaking change)
  • Other (non-breaking change)
  • Other (breaking change)
  • Release preparation

What does this solve?

Outstanding questions

What databases have you tested with?

  • Snowflake
  • Google BigQuery
  • Databricks
  • Spark
  • N/A

@glsdown glsdown temporarily deployed to Approve Integration Tests September 29, 2023 16:15 — with GitHub Actions Inactive
@glsdown glsdown temporarily deployed to Approve Integration Tests September 29, 2023 16:15 — with GitHub Actions Inactive
@glsdown glsdown temporarily deployed to Approve Integration Tests September 29, 2023 16:15 — with GitHub Actions Inactive
@glsdown glsdown had a problem deploying to Approve Integration Tests September 29, 2023 16:15 — with GitHub Actions Failure
@glsdown glsdown temporarily deployed to Approve Integration Tests September 29, 2023 16:21 — with GitHub Actions Inactive
@glsdown glsdown temporarily deployed to Approve Integration Tests September 29, 2023 16:21 — with GitHub Actions Inactive
@glsdown glsdown temporarily deployed to Approve Integration Tests September 29, 2023 16:21 — with GitHub Actions Inactive
@glsdown glsdown had a problem deploying to Approve Integration Tests September 29, 2023 16:21 — with GitHub Actions Failure
@glsdown glsdown temporarily deployed to Approve Integration Tests October 2, 2023 18:26 — with GitHub Actions Inactive
@glsdown glsdown temporarily deployed to Approve Integration Tests October 2, 2023 18:26 — with GitHub Actions Inactive
@glsdown glsdown had a problem deploying to Approve Integration Tests October 2, 2023 18:26 — with GitHub Actions Failure
@glsdown glsdown temporarily deployed to Approve Integration Tests October 3, 2023 08:56 — with GitHub Actions Inactive
@glsdown glsdown temporarily deployed to Approve Integration Tests October 3, 2023 08:56 — with GitHub Actions Inactive
@glsdown glsdown temporarily deployed to Approve Integration Tests October 3, 2023 08:56 — with GitHub Actions Inactive
@glsdown glsdown had a problem deploying to Approve Integration Tests October 3, 2023 08:56 — with GitHub Actions Failure
@glsdown glsdown merged commit 5d2df3f into main Oct 5, 2023
4 of 5 checks passed
@glsdown glsdown deleted the fix/tidy-up-execution-timings branch October 5, 2023 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants