Use an Artifact ID rather than a composite OR statment in several places. #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Niall Woodward <niall@niallrees.com>
alanmcruickshank
had a problem deploying
to
Approve Integration Tests
alanmcruickshank
had a problem deploying
to
Approve Integration Tests
alanmcruickshank
had a problem deploying
to
Approve Integration Tests
alanmcruickshank
commented
Feb 2, 2022
Comment on lines
39
to
40
| -- This ID provides a reliable ID, regardless of whether running in a local or cloud environment. | ||
| sha2_hex(coalesce(dbt_cloud_run_id, command_invocation_id), 256) as artifact_run_id, |
There was a problem hiding this comment.
@NiallRees - this is the bit that I'd love your view on.
There was a problem hiding this comment.
Great idea. Linked issue: #53
alanmcruickshank
had a problem deploying
to
Approve Integration Tests
NiallRees
reviewed
Feb 2, 2022
| select | ||
| command_invocation_id, | ||
| dbt_cloud_run_id | ||
| select artifact_run_id |
There was a problem hiding this comment.
Even if we're joining on this new key, can we keep the command_invocation_id and dbt_cloud_run_id in these models? Both are potentially useful to users.
There was a problem hiding this comment.
Oh nvm they weren't in the model output anyway.
NiallRees
approved these changes
Feb 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In several places we had:
This PR replaces that idiom with a single identifier created in the base artifacts model, made from a coalesce of the two original IDs, then hashed. I think it's much cleaner and more future proof.
Would appreciate feedback on whether
SHA2is overkill or whetherMD5might be more pragmatic @NiallRees.