Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

date_or_null fix #123

Merged
merged 3 commits into from
Apr 10, 2017
Merged

date_or_null fix #123

merged 3 commits into from
Apr 10, 2017

Conversation

tabermike
Copy link
Contributor

fix: expect_json_types when type is :date_or_null and actual value is null
Includes tests to validate change

Dates may be null until specifically set; example response: {"dateDeleted": null}
This patch corrects invalid type failure when response is a valid date; example response:
{"dateDeleted": "2009-12-09T06:00:00Z"} and expected type is :date_or_null

@coveralls
Copy link

coveralls commented Dec 12, 2016

Coverage Status

Coverage increased (+0.1%) to 99.103% when pulling dbd6fef on Widen:date-or-null-fix into 55311ac on brooklynDev:master.

@sethpollack sethpollack merged commit f0bafe9 into brooklynDev:master Apr 10, 2017
@sethpollack
Copy link
Collaborator

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants