Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/matchers/expect json sizes #18

Merged

Conversation

PikachuEXE
Copy link
Contributor

Besides the README & code & spec, I have:

  • Add CHANGELOG
  • Make expect_json_types accept Proc as expectation (not expect_json though)
  • Rename some variables & add some blank lines for readability

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) when pulling 4fb810a on PikachuEXE:feature/matchers/expect-json-sizes into e453629 on brooklynDev:master.

brooklynDev added a commit that referenced this pull request Oct 23, 2014
@brooklynDev brooklynDev merged commit e3d75dc into brooklynDev:master Oct 23, 2014
@PikachuEXE PikachuEXE deleted the feature/matchers/expect-json-sizes branch October 24, 2014 01:07
@jsvisa
Copy link
Contributor

jsvisa commented Nov 5, 2014

I think @PikachuEXE you should update the gem version the same time, because it add some new apis.:)

@PikachuEXE
Copy link
Contributor Author

I think the versioning is the author's responsibility

@jsvisa
Copy link
Contributor

jsvisa commented Nov 5, 2014

@brooklynDev , It's better to add the gem version along with the release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants