Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate word and newline in error message #60

Merged
merged 1 commit into from
Jul 2, 2015
Merged

Remove duplicate word and newline in error message #60

merged 1 commit into from
Jul 2, 2015

Conversation

jsborjesson
Copy link
Contributor

No description provided.

@sethpollack
Copy link
Collaborator

Thanks @alcesleo! Can you fix the failing tests? Also please leave the newline in.

@jsborjesson
Copy link
Contributor Author

Sure thing, just edited it on github, it looks like the other similar messages do not have a newline though, what is the purpose of it?

@sethpollack
Copy link
Collaborator

I was trying to keep consistent with rspec. They use this format "\nexpected: #{expected_formatted}\n got: #{actual_formatted}\n\n(compared using eql?)\n"

We should probably add the expected: and got: to our messages.

@jsborjesson
Copy link
Contributor Author

I force pushed my branch to do what you asked :)

@sethpollack
Copy link
Collaborator

Ok thanks!

sethpollack added a commit that referenced this pull request Jul 2, 2015
Remove duplicate word in error message
@sethpollack sethpollack merged commit 270382c into brooklynDev:master Jul 2, 2015
@jsborjesson jsborjesson deleted the patch-1 branch July 3, 2015 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants