Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DELETE functionality when options are passed in #77

Merged
merged 2 commits into from
Sep 24, 2015
Merged

Add DELETE functionality when options are passed in #77

merged 2 commits into from
Sep 24, 2015

Conversation

dmhalejr
Copy link
Contributor

I have a delete endpoint that needs to get passed in a json_body and keep receiving wrong number of arguments (0 for 1..2) I think this change in the gem might help?

The parameters needed for the DELETE:

{
  "contact_ids": [
    "string"
  ]
}

First PR to an open source project so please be gentle! :)

@brooklynDev
Copy link
Owner

Thanks for the commit. At first I was hesitant because I was always under the impression that DELETE requests shouldn't have a body, but after reading up on it, it seems to be more of a gray area than a conclusive one, so I'll pull this in. Thanks!

brooklynDev added a commit that referenced this pull request Sep 24, 2015
Add DELETE functionality when options are passed in
@brooklynDev brooklynDev merged commit 8eff44c into brooklynDev:master Sep 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants