JcloudsLocation for port-forwarding #1082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Refactors methods for creation of users - Adds JcloudsPortForwarderExtension - Calls out to port-forwarder for port 22, if configured
|
Brooklyn Central » brooklyn #1379 SUCCESS |
| sshProps.put("port", port); | ||
| if (initialPassword.isPresent()) sshProps.put("password", initialPassword.get()); | ||
| if (initialPrivateKey.isPresent()) sshProps.put("privateKeyData", initialPrivateKey.get()); | ||
| if (initialPrivateKey.isPresent()) sshProps.put("privateKeyData", initialPrivateKey.get()); |
|
@aledsage I've made minor comments that I think are worth addressing, but otherwise this looks good. New live test passed on AWS. As @richardcloudsoft mentioned, is there anything to go alongside this for the brooklyn-networking project? |
|
The changes in this pull request cause the build of the cloudstack module in brooklyn-networking to fail: |
|
@sjcorbett @richardcloudsoft thanks, I've incorporated those comments (see the most recent commit). Are you happy for me to merge now? I've updated the brooklyn-networking downstream project at https://github.com/cloudsoft/brooklyn-networking/pull/3 |
|
@aledsage Go for it. |
aledsage
added a commit
that referenced
this pull request
Dec 3, 2013
…rtforwarding JcloudsLocation for port-forwarding
aledsage
added a commit
to aledsage/legacy-brooklyn
that referenced
this pull request
Dec 11, 2013
- in brooklyncentral#1082 a superset of these changes were done in master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some changes I've had sitting around for far too long, that I've finally revisited! These were originally started in github.com/cloudsoft/brooklyn-networking