Cleaned

wantslistutils.go

@@ -32,14 +32,15 @@ func (s *Server) processWantLists(ctx context.Context) {
 			if err == nil {
 				toUpdateToWanted.Status = pb.WantListEntry_WANTED
 			}
-
 		}
 
-		for _, v := range list.Wants {
-			if v.Status == pb.WantListEntry_WANTED {
-				_, err := s.rcBridge.getRecord(ctx, v.Want)
-				if err == nil {
-					v.Status = pb.WantListEntry_IN_COLLECTION
+		if toUpdateToWanted == nil {
+			for _, v := range list.Wants {
+				if v.Status == pb.WantListEntry_WANTED {
+					_, err := s.rcBridge.getRecord(ctx, v.Want)
+					if err == nil {
+						v.Status = pb.WantListEntry_IN_COLLECTION
+					}
 				}
 			}
 		}

wantslistutils_test.go

@@ -34,6 +34,7 @@ func InitTestServer() *Server {
 	s.SkipLog = true
 	s.GoServer.KSclient = *keystoreclient.GetTestClient(".test")
 	s.wantBridge = &testWantBridge{}
+	s.rcBridge = &testRcBridge{}
 	return s
 }
 
@@ -82,3 +83,26 @@ func TestFirstEntryUpdated(t *testing.T) {
 		t.Errorf("Want has not been updated following first complete")
 	}
 }
+
+func TestFirstEntryUpdatedToCollection(t *testing.T) {
+	s := InitTestServer()
+	s.AddWantList(context.Background(), &pb.AddWantListRequest{
+		Add: &pb.WantList{
+			Name: "TestList",
+			Wants: []*pb.WantListEntry{
+				&pb.WantListEntry{Index: 1, Want: 123, Status: pb.WantListEntry_WANTED},
+				&pb.WantListEntry{Index: 2, Want: 125},
+			},
+		},
+	})
+
+	s.processWantLists(context.Background())
+
+	lists, err := s.GetWantList(context.Background(), &pb.GetWantListRequest{})
+	if err != nil {
+		t.Fatalf("Error getting wants: %v", err)
+	}
+	if lists.Lists[0].Wants[0].Status != pb.WantListEntry_IN_COLLECTION {
+		t.Errorf("Want has not been updated following first complete: %v", lists.Lists[0].Wants[0])
+	}
+}