fix: exclude hidden pages from automatic breadcrumb generation

references: #114
brotkrueml · Jun 2, 2023 · e27c882 · e27c882
1 parent d0cecc6
commit e27c882
Show file tree

Hide file tree

Showing 2 changed files with 38 additions and 0 deletions.
diff --git a/Classes/EventListener/AddBreadcrumbList.php b/Classes/EventListener/AddBreadcrumbList.php
@@ -57,6 +57,10 @@ public function __invoke(InitialiseTypesEvent $event): void
                 break;
             }
 
+            if ($page['hidden'] ?? false) {
+                continue;
+            }
+
             if ($page['nav_hide'] ?? false) {
                 continue;
             }

diff --git a/Tests/Unit/EventListener/AddBreadcrumbListTest.php b/Tests/Unit/EventListener/AddBreadcrumbListTest.php
@@ -193,6 +193,40 @@ public function rootLineProvider(): iterable
             '{"@context":"https://schema.org/","@type":"BreadcrumbList","itemListElement":{"@type":"ListItem","item":{"@type":"WebPage","@id":"https://example.org/the-page/"},"name":"A page","position":"1"}}',
         ];
 
+        yield 'Rootline with a hidden page' => [
+            [
+                3 => [
+                    'uid' => 3,
+                    'doktype' => PageRepository::DOKTYPE_DEFAULT,
+                    'title' => 'A page',
+                    'nav_title' => '',
+                    'nav_hide' => '0',
+                    'hidden' => '1',
+                    'is_siteroot' => '0',
+                    'tx_schema_webpagetype' => '',
+                ],
+                2 => [
+                    'uid' => 2,
+                    'doktype' => PageRepository::DOKTYPE_DEFAULT,
+                    'title' => 'A page',
+                    'nav_title' => '',
+                    'nav_hide' => '0',
+                    'is_siteroot' => '0',
+                    'tx_schema_webpagetype' => '',
+                ],
+                1 => [
+                    'uid' => 1,
+                    'doktype' => PageRepository::DOKTYPE_DEFAULT,
+                    'title' => 'Site root page',
+                    'nav_title' => '',
+                    'nav_hide' => '0',
+                    'is_siteroot' => '1',
+                    'tx_schema_webpagetype' => '',
+                ],
+            ],
+            '{"@context":"https://schema.org/","@type":"BreadcrumbList","itemListElement":{"@type":"ListItem","item":{"@type":"WebPage","@id":"https://example.org/the-page/"},"name":"A page","position":"1"}}',
+        ];
+
         yield 'Rootline with siteroot not on first level' => [
             [
                 2 => [