Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Events and Time Slots deleted from Mobilize are not deleted from Airtable #59

Closed
brotskydotcom opened this issue Sep 30, 2020 · 1 comment
Closed

Events and Time Slots deleted from Mobilize are not deleted from Airtable #59

brotskydotcom opened this issue Sep 30, 2020 · 1 comment
Assignees
@brotskydotcom
Labels
bug Something isn't working

Comments

@brotskydotcom
Copy link
Owner

The current integration views each Mobilize load as incremental, but in fact it's absolute. So we need to change the integration to delete any events and timeslots that aren't in the next upload (and maybe the shifts associated with them - we might have to only do deletions on a go-forward basis).
@brotskydotcom brotskydotcom added the bug Something isn't working label Sep 30, 2020
@brotskydotcom brotskydotcom self-assigned this Sep 30, 2020
brotskydotcom added a commit that referenced this issue Oct 4, 2020
@brotskydotcom
Fix #59: remove events and shifts from Airtable when removed from Mob…
e4c3d3e 
…ilize.

This involved a few structural changes in item processing:
- each item list has to be classified as to whether it is a webhook list or an event/shift list.
- when processing event/shift lists, we need to keep track of which events/shifts it contains.
- at the end of each event/shift list, we need to delete any records of that type that the cache contained but the list did not.

Making the above changes required making some cache changes:
- we need to keep the record ID as well as the mod date for each record in the cache.
- we need to keep track of all the keys for records of each type.

These cache changes required changing the cache key format, so that the old cache and the new cache implementations don't collide.
@brotskydotcom brotskydotcom mentioned this issue Oct 6, 2020
Closed
@brotskydotcom
Copy link
Owner Author

So this came back when I got rid of the cache. But I realize it's slightly different: we should remove old events but not old shifts. We should transfer all the shifts and just not link them to events that have been deleted.

brotskydotcom added a commit that referenced this issue Oct 15, 2020
@brotskydotcom
Fix #59 again: delete events from Airtable when deleted from Mobilize.
78c47a5 
Also made a change to retain all shifts even if they have no current event IDs, since we want the historical data.

Also updated an incorrect attribution string in the logs.
brotskydotcom added a commit that referenced this issue Oct 15, 2020
@brotskydotcom
Fix #59 again: delete events from Airtable when deleted from Mobilize. (
9e807d0 
#71)

Also made a change to retain all shifts even if they have no current event IDs, since we want the historical data.

Also updated an incorrect attribution string in the logs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brotskydotcom brotskydotcom

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@brotskydotcom