Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updating utm_source field to contacts table #42

Merged
merged 3 commits into from
Aug 20, 2020
Merged

updating utm_source field to contacts table #42

merged 3 commits into from
Aug 20, 2020

Conversation

huayu-ouyang
Copy link
Contributor

If the shift contains a utm_source code, add/update this field in the contacts table

@brotskydotcom brotskydotcom temporarily deployed to public-servi-utm-source-af2nsm August 19, 2020 00:34 Inactive
brotskydotcom
brotskydotcom previously approved these changes Aug 19, 2020
View reviewed changes
Copy link
Owner

@brotskydotcom brotskydotcom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. Are you also going to update fetch_shifts.py as well?

@brotskydotcom brotskydotcom temporarily deployed to public-servi-utm-source-af2nsm August 19, 2020 20:40 Inactive
@huayu-ouyang
Copy link
Contributor Author

This looks great. Are you also going to update fetch_shifts.py as well?

I just deleted it & transfer_shifts.py

brotskydotcom
brotskydotcom previously approved these changes Aug 20, 2020
View reviewed changes
@brotskydotcom brotskydotcom mentioned this pull request Aug 20, 2020
Closed
@brotskydotcom
Fix #43 temporarily: make shift do custom field name mapping.
9e81008 
A better fix for this issue is to remove the asymmetry so both custom and target fields have the same naming scheme.  I've left a #TODO in so I fix this later.
@brotskydotcom brotskydotcom temporarily deployed to public-servi-utm-source-af2nsm August 20, 2020 06:01 Inactive
brotskydotcom
brotskydotcom approved these changes Aug 20, 2020
View reviewed changes
Copy link
Owner

@brotskydotcom brotskydotcom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to verify the fix of #43 in the review app on Heroku.

@brotskydotcom brotskydotcom merged commit d6e836b into master Aug 20, 2020
@brotskydotcom brotskydotcom deleted the utm_source_codes branch August 22, 2020 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brotskydotcom brotskydotcom brotskydotcom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@huayu-ouyang @brotskydotcom