Chained method indentation fails when ? operator is inline

[j0ni]

I have observed that something like this:

    ContextBuilder::new("Rain", 1024, 768)
        .quit_on_escape(true)
        .build()?
        .run(GameState::new)

is indented instead like this:

    ContextBuilder::new("Rain", 1024, 768)
        .quit_on_escape(true)
        .build()?
    .run(GameState::new)

I may try again to fix it (my attempt #222 here didn't work, because I didn't fully grok the function) but for now here's a bug report.

[j0ni]

I just noticed that this problem doesn't exist in Doom's setup, which has rustic pinned at commit f7d5ac0, from December 2020. I haven't looked into its config and/or hacks yet so it may not be a regression per se. Interesting clue though.

[brotzeit]

Hmmm, I know that the doom-emacs people often apply fixes for packages to doom-emacs and not to the affected packages. I'll take a look.

[j0ni]

BTW, By making this change in rustic-interaction.el I'm getting the correct behaviour in the case I've described:

   (let ((continue t))
     (while continue
       (let ((starting (point)))
-        (skip-chars-backward "[:space:]\n")
+        (skip-chars-backward "?[:space:]\n")
         (when (rustic-looking-back-str "*/")
           (backward-char))
         (when (rustic-in-str-or-cmnt)

but I have not spent any time doing anything else, so for all I know it might break something else.

[brotzeit]

I didn't add this code myself so I'm a little hesitant, as you mentioned we can't be sure if this doesn't introduce other bugs. I would have a better feeling applying this change if we had some tests.

[brotzeit]

This is now a rust-mode issue since rustic is no longer a fork of rust-mode and requires it as dependency.