Fix org-babel workflow when auto wrapping main function #485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This bug is easily reproducible when you use try something like this:
```
let x = [1,2,3,4,5,6];
println!("{x:?}");
```
And then try executing it. While you will get the result properly, you
could see in the Messages buffer that that would be some errors
related to compilation buffer.
And the reason is this: It tries to do rustfmt on the babel block and
fails. In this fix, I just disable doing rustfmt when we have enabled
automatic wrapping or when we instruct it to wrap the main function.
Another alternative fix could be do rustfmt on the wrapped main
function and the remove the wrapped main function and render it again
on the babel blocks. But IMO, that's going to be very fragile.
|
Works for me. |
brotzeit
approved these changes
Jan 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bug is easily reproducible when you use try something like this:
And then try executing it. While you will get the result properly, you could see in the Messages buffer that that would be some errors related to compilation buffer.
And the reason is this: It tries to do rustfmt on the babel block and fails. In this fix, I just disable doing rustfmt when we have enabled automatic wrapping or when we instruct it to wrap the main function.
Another alternative fix could be do rustfmt on the wrapped main function and the remove the wrapped main function and render it again on the babel blocks. But IMO, that's going to be very fragile.