Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose Faker again #8

Open
esambo opened this issue Dec 31, 2014 · 7 comments
Open

Expose Faker again #8

esambo opened this issue Dec 31, 2014 · 7 comments

Comments

@esambo
Copy link

esambo commented Dec 31, 2014

Faker used to be globally exposed which allowed the consuming Rails app to do things like: Faker.Address.streetAddress()
But the introduction of gulp in #2 stopped doing this which now causes the error: Uncaught ReferenceError: Faker is not defined and stops Peteshow from loading.

I wouldn't mind if Faker would be scoped within Peteshow, but such a breaking change should probably be mentioned in a Changelog.md file

Affected apps based on a GitHub search are:

@esambo
Copy link
Author

esambo commented Dec 31, 2014

But why can't we make Faker globally accessible? It's a public library and not an implementation detail. It is a dependency. It is not modified by Faker and therefore probably should NOT live within the Peteshow namespace!

@brousalis
Copy link
Owner

It wasn't on purpose. When Kevin did the gulp changeover, he broke that on accident.

I'll fix it shortly.

@esambo
Copy link
Author

esambo commented Jan 2, 2015

There seem to be some other errors too when trying to fill out a form with Peteshow

@brousalis
Copy link
Owner

I think its pretty safe to say Kevin's gulp implementation is broken and master is dirty. I'll revert everything.

However I never released his changes to the gem itself, so the gem is still stable.

@esambo
Copy link
Author

esambo commented Jan 2, 2015

Yes, 0.8.6 (referencing ref 1d93e3f) works, and rebasing #2 onto that last commit before gulp works fine

@itsthatguy
Copy link
Collaborator

Hey!

@itsthatguy
Copy link
Collaborator

Digging into all of this now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants