Skip to content
This repository has been archived by the owner on Aug 3, 2022. It is now read-only.

fix - update about page #325

Merged
merged 1 commit into from Oct 6, 2020
Merged

fix - update about page #325

merged 1 commit into from Oct 6, 2020

Conversation

paulstey
Copy link
Member

@paulstey paulstey commented Oct 6, 2020

This PR fixes 2 things on the About page; in particular, we update Sam's title to HPC Architect, and we remove Andrew's picture.

Check the types of changes present in this PR:

  • 馃悰 Bug
  • 馃悏 Feature
  • 馃惛 Data (data folder - people/opportunities)
  • 馃惗 Content (content folder)
  • 馃悺 Other. Specify:

Checklist:

  • Commitizen was used for all commits.
  • Local site looks as expected after changes.
  • Contributing guidelines were followed.
  • If changes affect development, was the README updated?
If PR to production

@paulstey paulstey requested a review from a team October 6, 2020 14:04
@fernandogelin fernandogelin temporarily deployed to review-app-fix-about-pa-2cavpv October 6, 2020 14:04 Inactive
@github-actions
Copy link

github-actions bot commented Oct 6, 2020

Technical Reviewer Checklist

Make sure the updates follow the contribution guidelines and the code is clear. Some of the things you should check:

  • All commits use conventional style
  • Website builds
  • Code is readable and easily understandable, with comments, but not commented out code
  • Spacing and indentation is constistent
  • README was updated (if needed) and update is comprehensive and useful
  • No extraneous files added, especially a .env or similar

@github-actions github-actions bot added the ready PR has completed waiting period - ready to merge label Oct 6, 2020
@mcmcgrath13
Copy link
Contributor

@paulstey I changed the type from a bug to data as this only touches the data folder

@paulstey
Copy link
Member Author

paulstey commented Oct 6, 2020

@paulstey I changed the type from a bug to data as this only touches the data folder

Thanks, @mcmcgrath13!!

@mcmcgrath13 mcmcgrath13 requested review from a team and removed request for a team October 6, 2020 14:09
@mcmcgrath13
Copy link
Contributor

and also the review group to website-dev. website-admin is only for PRs to prod.

@mcmcgrath13 mcmcgrath13 merged commit a606be5 into master Oct 6, 2020
@mcmcgrath13 mcmcgrath13 deleted the fix-about-page branch October 6, 2020 14:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ready PR has completed waiting period - ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants