Slows down iphoneX

[jemilox]

Was using this until we noticed huge lag problems on only the iphoneX.

Narrowed it down to this library. Not completely sure what the issue was, but removing it for now.

[browniefed]

Thanks, I'd be curious if you could share an example of the string you were attempting to tick?

[jemilox]

They were integers between 0-1000

…

On Mon, Oct 29, 2018 at 1:02 PM Jason Brown ***@***.***> wrote: Thanks, I'd be curious if you could share an example of the string you were attempting to tick? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#10 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ASzxodrNP9we785WEAuROXIX7MbZp6dUks5up0LJgaJpZM4X8u9C> .

[browniefed]

Sorry, should have clarified more. Were you rendering a lot of these? What was the situation where you were seeing slowness.

[jemilox]

Nope, we were rending once every like 5 seconds at the fastest. The rest of our app would get really slow. It was affecting everything. As soon as I cut out the ticker, everything stopped lagging. I checked for number of renders on my component that was using it, and it only rendered once. It worked just find on android and lower versions of iphone, which was really weird.

…

On Mon, Oct 29, 2018 at 1:46 PM Jason Brown ***@***.***> wrote: Sorry, should have clarified more. Were you rendering a lot of these? What was the situation where you were seeing slowness. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#10 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ASzxod8wLJ1KAI6fIbLGEMS_Ak1YZR1Qks5up0zsgaJpZM4X8u9C> .

[browniefed]

Are you sure you didn't turn on slow animations?

[browniefed]

I believe you can toggle with cmd + shift + t, and or with the simulator open you can toggle it from the debug menu.

[jemilox]

I am positive :( It was happening when we deployed to real phones too. It is possible this is due to something else, however, I narrowed it down to the actual component.

…

On Tue, Oct 30, 2018 at 4:27 PM Jason Brown ***@***.***> wrote: I believe you can toggle with cmd + shift + t, and or with the simulator open you can toggle it from the debug menu. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#10 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ASzxoYKRimfd7MTaFkTazQLK6ZFSG5vZks5uqMQ0gaJpZM4X8u9C> .

[gilberger]

I've been experiencing the same issue.

Seems to be something with the handleMeasure function, triggered by onLayout prop of the container View.
the solution I found was to verify that this.state.measured is false before updating the height of the layout.

also added a PR for that #11

[browniefed]

v2.20 has been released.

[jemilox]

yay! Thanks!

…

On Tue, Nov 13, 2018 at 2:58 PM Jason Brown ***@***.***> wrote: v2.20 has been released. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#10 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ASzxocHGpdYii828uWmptlSI1SWtYdh-ks5uuzJ5gaJpZM4X8u9C> .

[slorber]

Hi,

I can confirm the slowness on iOS.
We noticed this on some iphone XS, which was surprising because the app did fine with older iphones.

It has been reported with an iphone 7 also.

I have not been able to reproduce this on my own ios hardware devices (older)

It seems @gilberger solution fixes the problem, but a bug remains due to react's event pooling. We must call e.persist() because when using setState with an update function (like it is now) there's no guarantee that this fn will be called in same batch and in my case it lead to errors.

PR with a simple fix here: #13