Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump PHP version to 7.1 #1338

Closed
mimmi20 opened this issue Apr 5, 2017 · 3 comments
Closed

bump PHP version to 7.1 #1338

mimmi20 opened this issue Apr 5, 2017 · 3 comments
Labels
enhancement

Comments

@mimmi20
Copy link
Member

mimmi20 commented Apr 5, 2017

With BrowscapPHP bumped to PHP 7.1, the builds are failing on travis. To solve this, Browscap should be bumped too.
@mimmi20 mimmi20 added the bug label Apr 5, 2017
@asgrim asgrim added enhancement and removed bug labels Apr 5, 2017
@asgrim
Copy link
Member

asgrim commented Apr 5, 2017

#1336 (fixing #1335) fixes the failing builds for now, but yes, I agree we should bump to 7.1 minimum :)

@jaydiablo
Copy link
Contributor

I believe this was bumped in #1543 no?

@mimmi20
Copy link
Member Author

mimmi20 commented Sep 28, 2017

Fixed in PR#1543.

@mimmi20 mimmi20 closed this as completed Sep 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jaydiablo @asgrim @mimmi20