Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scrollY API - measured position differs from intended position #12

Closed
reeteshranjan opened this issue Jul 31, 2017 · 2 comments
Closed

scrollY API - measured position differs from intended position #12

reeteshranjan opened this issue Jul 31, 2017 · 2 comments
Assignees
@reeteshranjan
Labels
browser limitation cantfix

Comments

@reeteshranjan
Copy link
Collaborator

  • Opera Mobile 11.50, Android 2.2 2.3 4 4.1, Mobile Safari 4 (iOS 3 3.2 4) 5 (iOS 4.3) 5.1 (iOS 5 5.1) 6 (iOS 6) 7 (iOS 7) 
     × should work to achieve desired scroll position (1016ms)
    Expected 98 to equal 100.
 × should run for a duration less than javascript frame interval (31ms)
    Expected 0 to equal 100.
 × should complete in a time close to given duration (1013ms)
    Expected 98 to equal 100.
 × should work from any scroll position (1011ms)
    Expected 98 to equal 100.
  • Android 4.2 
     × should work to achieve desired scroll position (1016ms)
    Expected 77 to equal 100.
 × should complete in a time close to given duration (1013ms)
    Expected 63 to equal 100.

Opera Mobile build: https://travis-ci.org/browsejs/browse.js/jobs/259179949
Android build: https://travis-ci.org/browsejs/browse.js/jobs/259179951
iOS build: https://travis-ci.org/browsejs/browse.js/jobs/259179952
@reeteshranjan reeteshranjan self-assigned this Jul 31, 2017
@reeteshranjan reeteshranjan added bug and removed bug labels Jul 31, 2017
@reeteshranjan
Copy link
Collaborator Author

reeteshranjan commented Aug 2, 2017 •
edited

As seen in the experiments done and documented in #11, the issues are proven to be platform specific which cannot be taken care of by any code. Given that scroll positions measurement did stabilize; but after more than 1s, and changing the tests accordingly to take the stabilized positions after more than 1s does not make sense, as most of other browsers do work as expected and sanely.

This would be marked as cantfix.

reeteshranjan added a commit that referenced this issue Aug 2, 2017
@reeteshranjan
Bug Fixes
b610b60 
Debugging #12
- A new test file tests/js/scrollY.js is added which has manually
  written tests (not Jasmine) where expected and measured scroll
  positions are sent back to server after a scrolling attempt.
- The server in tests/server/server.js was modified to accept above
  data and print for debugging
- This test was tried with Jasmine completely disabled to see what
  changes and pinpoint the cause of the issue. It's being checked in
  as disabled, though, as it was proven that issues with measured
  scroll positions not matching expected happen due to platform issues,
  and there is nothing that our API or test environment do to cause
  these issues.

Fixes #3
- Sad IE 6! That's all we can say. An element with 10px fades-in, and
  it says it is 19px high, and in fact it is seen that way as well in
  the session. Change the height to 20px, and things are back to track!!

README.md updated
- With changes as per bugs fixed by this release and other bugs
  closed as wontfix

Opera mobile config reverted
- Randomly opera mobile browsers fail. Best to keep all avaialable
  in our test config.
@reeteshranjan reeteshranjan added this to the 1.0 milestone Aug 16, 2017
@reeteshranjan
Copy link
Collaborator Author

iOS 8+ works fine like other modern browsers, when it comes to measured and expected positions post scrolling being identical (as expected).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@reeteshranjan reeteshranjan

Labels
browser limitation cantfix
Milestone
No milestone
Development

No branches or pull requests
1 participant
@reeteshranjan