Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add default browser support #123

Merged
merged 10 commits into from
Jan 26, 2021
Merged

Add default browser support #123

merged 10 commits into from
Jan 26, 2021

Commits on Jan 25, 2021

  1. Add default browser support on linux

    @ObaraEmmanuel
    ObaraEmmanuel committed Jan 25, 2021
    Configuration menu
    Copy the full SHA
    20e7684 View commit details
    Browse the repository at this point in the history

  2. add default browser support windows

    @ObaraEmmanuel
    ObaraEmmanuel committed Jan 25, 2021
    Configuration menu
    Copy the full SHA
    75f9f4a View commit details
    Browse the repository at this point in the history

  3. [CODE] Add aliases attribute

    @ObaraEmmanuel
    ObaraEmmanuel committed Jan 25, 2021
    Configuration menu
    Copy the full SHA
    bec88d1 View commit details
    Browse the repository at this point in the history

  4. [CODE] Move get_browser and default_browser to utils

    @ObaraEmmanuel
    ObaraEmmanuel committed Jan 25, 2021
    Configuration menu
    Copy the full SHA
    8a37654 View commit details
    Browse the repository at this point in the history

  5. [TESTS] add tests for default browser on linux and mac

    @Samyak2 @ObaraEmmanuel
    Samyak2 authored and ObaraEmmanuel committed Jan 25, 2021
    Configuration menu
    Copy the full SHA
    3268cdb View commit details
    Browse the repository at this point in the history

  6. [TESTS] add some simple tests for default browser on windows

    @Samyak2 @ObaraEmmanuel
    Samyak2 authored and ObaraEmmanuel committed Jan 25, 2021
    Configuration menu
    Copy the full SHA
    b9e4011 View commit details
    Browse the repository at this point in the history

  7. default-browser: handle cases when webbrowser returns None 

    Also use winreg imports from winreg namespace instead of importing them
directly.
    @Samyak2 @ObaraEmmanuel
    Samyak2 authored and ObaraEmmanuel committed Jan 25, 2021
    Configuration menu
    Copy the full SHA
    df8f85d View commit details
    Browse the repository at this point in the history

  8. [CODE] Refactor default browser fetching

    @ObaraEmmanuel
    ObaraEmmanuel committed Jan 25, 2021
    Configuration menu
    Copy the full SHA
    2b5afcc View commit details
    Browse the repository at this point in the history

  9. [CODE]Add default browser support for Vivaldi

    @ObaraEmmanuel
    ObaraEmmanuel committed Jan 25, 2021
    Configuration menu
    Copy the full SHA
    83154d5 View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2021

  1. [DOCS] add default browser in README and fix minor issues in docs 

    Highlighted default browser as a feature in the README since the
feature is a bit discreet.

Fixed a spacing issues in `aliases :`, moved docstring of `aliases`
to the correct position (bottom of it) and fixed some references
to `browser_history.generic.Browser`.
    @Samyak2
    Samyak2 committed Jan 26, 2021
    Configuration menu
    Copy the full SHA
    de46ff6 View commit details
    Browse the repository at this point in the history