You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jul 27, 2018. It is now read-only.
So if you're on say about:newtab and then navgiate away to say wikipedia.com you'll see titlebar in following states:
"New Tab"
"file://.../newtab/index.html"
"wikipedia.org"
"Wikipedia"
2nd is definitely something you should not see, maybe 3rd should not be displayed either.
What I think is happening is:
on LoadStart titel is blanked out, but we don't know url being loaded so we can't update it in model, which is why you see url of the about:newtab page.
Once we receive LocationChange event we update url so you do see the wikipedia.org.
Once we receive TitleChange event we finally display Wikipedia.
So there are two problems that make it difficult to have better experience:
On LoadStart we don't know what page is being loaded, which we probably should but that requires changes to the event to carry that info.
We could probably set title to Loading... on LoadStart and clear title on LoadEnd, but then there is no guarantee as far as I can tell that TitleChange won't be fired prior to LoadEnd in which case we wind up with url's always instead of titles (unless we check if title is different from Loading... before clearing it but that seems hacky, what if that's a title page has set itself).
I think it would make most sense to fix LoadStart event so it carries information about the uri being loaded. My second choice would be to clear out title on LocationChange event so we skip 2nd title although that could mean you'll see old title for little longer.
The text was updated successfully, but these errors were encountered:
So if you're on say
about:newtab
and then navgiate away to saywikipedia.com
you'll see titlebar in following states:2nd is definitely something you should not see, maybe 3rd should not be displayed either.
What I think is happening is:
LoadStart
titel is blanked out, but we don't knowurl
being loaded so we can't update it in model, which is why you see url of theabout:newtab
page.LocationChange
event we updateurl
so you do see thewikipedia.org
.TitleChange
event we finally displayWikipedia
.So there are two problems that make it difficult to have better experience:
LoadStart
we don't know what page is being loaded, which we probably should but that requires changes to the event to carry that info.Loading...
onLoadStart
and clear title onLoadEnd
, but then there is no guarantee as far as I can tell thatTitleChange
won't be fired prior toLoadEnd
in which case we wind up with url's always instead of titles (unless we check iftitle
is different fromLoading...
before clearing it but that seems hacky, what if that's a title page has set itself).I think it would make most sense to fix
LoadStart
event so it carries information about theuri
being loaded. My second choice would be to clear out title onLocationChange
event so we skip 2nd title although that could mean you'll see old title for little longer.The text was updated successfully, but these errors were encountered: