Skip to content
This repository has been archived by the owner on Jul 27, 2018. It is now read-only.

There is brief moment when you navigate away from page when you see previous page url #1041

Open
Gozala opened this issue May 20, 2016 · 0 comments
Labels
Milestone

Comments

@Gozala
Copy link
Contributor

Gozala commented May 20, 2016

So if you're on say about:newtab and then navgiate away to say wikipedia.com you'll see titlebar in following states:

  1. "New Tab"
  2. "file://.../newtab/index.html"
  3. "wikipedia.org"
  4. "Wikipedia"

2nd is definitely something you should not see, maybe 3rd should not be displayed either.

What I think is happening is:

  1. on LoadStart titel is blanked out, but we don't know url being loaded so we can't update it in model, which is why you see url of the about:newtab page.
  2. Once we receive LocationChange event we update url so you do see the wikipedia.org.
  3. Once we receive TitleChange event we finally display Wikipedia.

So there are two problems that make it difficult to have better experience:

  1. On LoadStart we don't know what page is being loaded, which we probably should but that requires changes to the event to carry that info.
  2. We could probably set title to Loading... on LoadStart and clear title on LoadEnd, but then there is no guarantee as far as I can tell that TitleChange won't be fired prior to LoadEnd in which case we wind up with url's always instead of titles (unless we check if title is different from Loading... before clearing it but that seems hacky, what if that's a title page has set itself).

I think it would make most sense to fix LoadStart event so it carries information about the uri being loaded. My second choice would be to clear out title on LocationChange event so we skip 2nd title although that could mean you'll see old title for little longer.

@Gozala Gozala added the ugly label May 20, 2016
@Gozala Gozala modified the milestone: Backlog Apr 5, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

1 participant