This repository has been archived by the owner on Jul 27, 2018. It is now read-only.
Refactor TextInput to avoid mixins.
#1201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Editable and Focusable are implemented as interfaces or components that you need to mix in. This a step towards making them more standard components that can be embedded pretty much like all other components are.
Embed Focusable, Editable, Control instead of mixing them in.
This was referenced Jul 29, 2016
|
r=me |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of the larger #1185 change & is based off #1200
Refactor TextInput to embed
Focusable,Editable,Controlinstead of mixing them in.