Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tests] log when openssl doesn't support cipher #38

Merged
merged 1 commit into from Sep 18, 2023
Merged

[Tests] log when openssl doesn't support cipher #38

merged 1 commit into from Sep 18, 2023

Conversation

kapouer
Copy link
Contributor

@kapouer kapouer commented Jan 3, 2018

This fixes #37.

calvinmetcalf
calvinmetcalf previously requested changes Jan 3, 2018
View reviewed changes
Copy link
Contributor

@calvinmetcalf calvinmetcalf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good except for the standard nits, also we probably want to to put a try catch around the stuff on line 30 too. Thanks for doing this.

test/index.js Outdated Show resolved Hide resolved
test/index.js Outdated Show resolved Hide resolved
test/index.js Outdated Show resolved Hide resolved
@kapouer
Copy link
Contributor Author

kapouer commented Jan 3, 2018

Seeing the fix for crypto-browserify i suppose that workaround is not right, then.

@calvinmetcalf
Copy link
Contributor

well the main one was just testing a single type of signature, so I just changed which one it was, for this one we have to test ALL of them so I think this is the right way.

@ljharb ljharb changed the title test: log when openssl doesn't support cipher [Tests] log when openssl doesn't support cipher Sep 18, 2023
@ljharb
Copy link
Member

ljharb commented Sep 18, 2023

I rebased this, and will do so again once I get CI restored, and then land it assuming it passes.

ljharb added a commit that referenced this pull request Sep 18, 2023
@ljharb
[Tests] handle openSSL not supporting a scheme
f5f17c2 
Technique from #38; see #37
@ljharb ljharb merged commit 5f6fb17 into browserify:master Sep 18, 2023
277 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

@calvinmetcalf calvinmetcalf calvinmetcalf left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

test failures depending on openssl version/flags
3 participants
@kapouer @calvinmetcalf @ljharb