Browserifying a file with for-of does not work

[domenic]

Throws a "error: parsing file", seems to originate in module-deps.

[ghost]

acorn allows:

var src = 'const xs = [1,2,3]\n'
  + 'for (let x in xs) console.log(x)'
var acorn = require('acorn');
console.log(acorn.parse(src, { ecmaVersion: 6 }));

but not:

var src = 'const xs = [1,2,3]\n'
  + 'for (const x in xs) console.log(x)'
var acorn = require('acorn');
console.log(acorn.parse(src, { ecmaVersion: 6 }));

I'm not sure if that's an acorn bug or the spec doesn't allow an iterator variable to be a constant. Anyways it might be good to raise with acorn since all of the underlying packages use acorn now.

[domenic]

for-of, not for-in :)

[domenic]

I can't confirm just by browsing GitHub but my guess is this was fixed in a more recent acorn version than the 0.9.0 that detective uses. @RReverser do you know if acorn supports for-of these days?

[ghost]

I wish acorn was at 1.0.0 already so I could just depend on ^1.0.0

[domenic]

Me too: acornjs/acorn#209

[ghost]

Same issue with const vs let or var:

x1.js:

const xs = [1,2,3]
for (let x of xs) console.log(x)

x2.js:

const xs = [1,2,3]
for (const x of xs) console.log(x)

$ browserify x1.js
(function e(t,n,r){function s(o,u){if(!n[o]){if(!t[o]){var a=typeof require=="function"&&require;if(!u&&a)return a(o,!0);if(i)return i(o,!0);var f=new Error("Cannot find module '"+o+"'");throw f.code="MODULE_NOT_FOUND",f}var l=n[o]={exports:{}};t[o][0].call(l.exports,function(e){var n=t[o][1][e];return s(n?n:e)},l,l.exports,e,t,n,r)}return n[o].exports}var i=typeof require=="function"&&require;for(var o=0;o<r.length;o++)s(r[o]);return s})({1:[function(require,module,exports){
const xs = [1,2,3]
for (let x of xs) console.log(x)

},{}]},{},[1]);

$ browserify x2.js

/tmp/x2.js:2
for (const x of xs) console.log(x)
     ^
ParseError: Unexpected token

[domenic]

Closing in favor of acornjs/acorn#213.