Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade util dependency to 0.11.x #1869

Open
domenic opened this issue Oct 8, 2018 · 1 comment
Open

Upgrade util dependency to 0.11.x #1869

domenic opened this issue Oct 8, 2018 · 1 comment

Comments

@domenic
Copy link
Contributor

domenic commented Oct 8, 2018

This would pull in browserify/node-util#25 and un-break the jsdom browser build.
domenic added a commit to jsdom/jsdom that referenced this issue Oct 8, 2018
@domenic
Revert "Remove some unnecessary dependencies"
8de427a 
This reverts commit 05706e5. Browserify does not include util.promisify, breaking the browser build: https://travis-ci.org/jsdom/jsdom/jobs/438454473. We can re-do this when browserify/browserify#1869 is fixed.
@goto-bus-stop
Copy link
Member

#1844 should be released soon. Right now the assert shim depends on a pinned 0.10.x version of util, so I'm hoping to get that upgraded at the same, to avoid pulling in multiple versions of the util shim in user bundles.

@vpulim vpulim mentioned this issue Feb 14, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@domenic @goto-bus-stop