More OS-agnostic tests, less dust in temporary folder #1183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use path.join() to get local styled filepath. Use Temp package to create temporary folders on OS specific place, plus wiping stuff after tests. Provide node-executable location to spawn().
ElNounch
force-pushed
the
os_agnostic_tests
branch
from
f470dc9
to
457853b
Compare
ghost
merged commit 
|
Thanks for the patches! If you'd like to help with windows compatibility (or whatever), I can add you as a contributor in the spirit of open open source on npm and github. |
1 task
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use path.join() to get local styled filepath.
Use Temp package to create temporary folders on OS specific place,
plus wiping stuff after tests.
Provide node-executable location to spawn().