Array support for b.exclude() and b.ignore() #1218
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you add tests for this behavior? |
|
Correct me, if I'm missing something, but is a test necessary here? The two functions simply recurse with arrays, so a test would involve mimicking the existing tests in a chain. A bit redundant. Of course, if you meant exactly that, no reason it can't be done. |
|
Any news on this one? I wouldn't mind having this merged as it currently is a bit inconsistent with other methods such as |
|
@christophercrouzet |
|
Thanks! |
|
@bakape for the record, I asked for tests not because it was difficult or tricky, but because we don't want to accidentally break it in the future. This PR looks reasonable. Let's see what another contributor thinks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple usability enhancement to prevent long exclude/ignore chains.