Update to make browserify work on Windows (recreated from #126, removed whitespace changes) #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…space changes; the intent is to improve support on Windows. Tested on Windows 7 (64).
|
I tried out this pull request on OS X and it broke. It didn't trigger any compile errors, but in the browser it failed to find the module I am requiring (dnode). My node_modules folder is several levels higher than my client code, but that shouldn't matter. |
ghost
closed this
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per your request in #126 (comment).
I naively translated the other pull request, I did not evaluate the code. However, my local testing worked fine (though I only tested on Windows).