Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update readable-stream to v3 #2070

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Update readable-stream to v3 #2070

wants to merge 5 commits into from

Conversation

legobeat
Copy link

@legobeat legobeat commented Sep 10, 2023 •
edited

This is a revival of a past attempt (#1938) which was partially applied in #1970 .

This follows up to also update the direct dependency on readable-stream to v3.

Resolves

This was referenced Sep 10, 2023
Open
Merged
Open
@legobeat legobeat marked this pull request as ready for review September 10, 2023 00:23
@legobeat legobeat mentioned this pull request Sep 10, 2023
Open
ljharb
ljharb requested changes Sep 10, 2023
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An upgrade that forces us to drop support of a node version is an upgrade not worth doing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@legobeat @ljharb