We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
If you try to walk the source of wysihtml5, detective will throw TypeError: Cannot set property 'parent' of null -- /node-detective/index.js:7:22
Here is a simple example that demonstrates the problem:
var detective = require('detective') , request = require('request') request('https://raw.github.com/xing/wysihtml5/master/dist/wysihtml5-0.4.0pre.js', function (err, response, src) { console.dir(detective(src)) })
Here is the node it's looping over. I can't figure out what is causing the node to be null, but it looks like that comes from esprima or escodegen
[ null, { type: 'Literal', value: 0 }, parent: { type: 'ArrayExpression', elements: [Circular], parent: { type: 'LogicalExpression', operator: '||', left: [Object], right: [Circular], parent: [Object] } } ]
I found this issue when upgrading to browserify v2.
The text was updated successfully, but these errors were encountered:
The null returned from esprima is caused by this [,0]. I'll throw together a test.
Sorry, something went wrong.
Checks for null before accessing node's parent.
8791a0e
Fixes browserify#19
06d72ee
Fixed by #21
Successfully merging a pull request may close this issue.
If you try to walk the source of wysihtml5, detective will throw TypeError: Cannot set property 'parent' of null -- /node-detective/index.js:7:22
Here is a simple example that demonstrates the problem:
Here is the node it's looping over. I can't figure out what is causing the node to be null, but it looks like that comes from esprima or escodegen
I found this issue when upgrading to browserify v2.
The text was updated successfully, but these errors were encountered: