Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(package): acorn-node@2.0.1 #85

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

aaditkamat
Copy link

@aaditkamat aaditkamat commented Feb 24, 2022

Closes #88

@avanelli
Copy link

@bcomnes @goto-bus-stop
Can we merge this?
Thanks

@goto-bus-stop
Copy link
Member

I believe this wasn't done yet because acorn-node@2 broke compatibility with some old node.js version. I'd like to fix that at some point (the point of acorn-node is to support new syntax as widely as possible, including on abandoned node.js versions) and then we can publish this too.

@rnegron
Copy link

rnegron commented Feb 8, 2023

@goto-bus-stop Heya! Is the acorn-node@2 compatibility issue still a concern? Would be great to have a newer release of detective and browserify in order to get support for the Node.js v15 logical assignment operators!

@legobeat
Copy link

legobeat commented Sep 4, 2023

@goto-bus-stop How old are we talking? The PR here seems to run fine down to Node.js v8 (which is itself EoL since 2019_ and I can't imagine supporting older than that can be a priority anymore?

https://github.com/legobeat/detective/actions/runs/6067551505/job/16459360769?pr=2

@rnegron
Copy link

rnegron commented Jan 30, 2024

@bcomnes @goto-bus-stop 👋🏻 Bumping this to ask if this is something that's still on your radar!

@bcomnes
Copy link
Member

bcomnes commented Jan 31, 2024

So sorry, I haven't been working with browserify in a few years and don't have enough context as to what even the right move to make here is without having to research it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to acorn-node@2.x
6 participants