use undeclared-identifiers #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goto-bus-stop
force-pushed
the
undeclared-identifiers
branch
2 times, most recently
from
81ecd55
to
b33dde0
Compare
goto-bus-stop
force-pushed
the
undeclared-identifiers
branch
from
b33dde0
to
b642b6d
Compare
before: $ npx ./bench/run.sh real 0m0.874s user 0m1.219s sys 0m0.060s Of that, 470ms were spent in `insert-module-globals`. after: $ npx ./bench/run.sh real 0m0.580s user 0m0.863s sys 0m0.056s Of that, 220ms were spent in `insert-module-globals`.
goto-bus-stop
force-pushed
the
undeclared-identifiers
branch
from
b642b6d
to
5b87648
Compare
|
Can you merge? |
To make sure that all the parsing in browserify happens in modules under the browserify org; this way anyone in the browserify github org can upgrade to newer parser versions if necessary.
|
ya. the consequences of a change like this are difficult to predict so hopefully it doesn't break anyone. if it does, i'll revert. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
undeclared-identifiers collects references to undeclared identifiers and their properties. It does much less work than lexical-scope so it is quite a bit faster.
before:
after: