Fix: resolve result is inconsistent with require.resolve if windows virtual drive is used #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
reviewed
May 23, 2022
ljharb
force-pushed
the
fix-vdrive-windows-path
branch
2 times, most recently
from
febb9d3
to
0008477
Compare
ljharb
pushed a commit
that referenced
this pull request
May 31, 2022
ljharb
added a commit
that referenced
this pull request
Jun 17, 2022
- [Fix] support windows virtual drive paths (#284) - [Deps] update `is-core-module` - [meta] use `npmignore` to autogenerate an npmignore file - [meta] do not publish `appveyor.yml` - [Dev Deps] update `eslint`, `@ljharb/eslint-config`, `tape` - [Test] add tests for `"main": false` - [Tests] fix tests on node v12.0-12.2 - [Test] add some `sync` coverage - [Test] fix incorrect `require.resolve` paths logic; enable these tests - [Tests] avoid tests breaking on node 11.11 - 11.13
ljharb
added a commit
that referenced
this pull request
Jun 17, 2022
v1.22.1 - [Fix] support windows virtual drive paths (#284) - [Deps] update `is-core-module` - [meta] use `npmignore` to autogenerate an npmignore file - [meta] do not publish `appveyor.yml` - [Dev Deps] update `eslint`, `@ljharb/eslint-config`, `tape` - [Test] add tests for `"main": false` - [Tests] fix tests on node v12.0-12.2 - [Test] add some `sync` coverage - [Test] fix incorrect `require.resolve` paths logic; enable these tests - [Tests] avoid tests breaking on node 11.11 - 11.13
ljharb
added a commit
that referenced
this pull request
Jun 18, 2022
Changes since v2.0.0-next.3: - [Breaking] ignore `SyntaxError`s from `readPackage`/`readPackageSync`, eg due to a malformed package.json Including all changes in v1.20.0 - v1.22.1: v1.22.1 - [Fix] support windows virtual drive paths (#284) - [Deps] update `is-core-module` - [meta] use `npmignore` to autogenerate an npmignore file - [meta] do not publish `appveyor.yml` - [Dev Deps] update `eslint`, `@ljharb/eslint-config`, `tape` - [Test] add tests for `"main": false` - [Tests] fix tests on node v12.0-12.2 - [Test] add some `sync` coverage - [Test] fix incorrect `require.resolve` paths logic; enable these tests - [Tests] avoid tests breaking on node 11.11 - 11.13 v1.22.0 - [New] add default support for `paths` to include `$HOME/.node_{modules,libraries}` (#273) - [Deps] update `is-core-module` v1.21.1 - [Fix] `bin/resolve`: allow `npx resolve` usage - [Dev Deps] update `eslint`, `@ljharb/eslint-config`, `aud`, `tape` - [Tests] add tests comparing `resolve.sync` to `require.resolve` v1.21.0 - [New] add top-level granular entry points - [New] add simple CLI util (#94) - [Refactor] `sync`: Do not throw on missing files in `isFile`/`isDirectory` (#256) - [Deps] update `is-core-module`, `path-parse` - [readme] pull in changes from default branch - [readme] remove defunct travis badge; update badges - [meta] backport FUNDING.yml - [meta] skip deleted files in `eclint` check - [meta] use `prepublishOnly`, for npm 7+ - [actions] reuse common workflows - [actions] pull in workflows from default branch - [actions] use `node/install` instead of `node/run`; use `codecov` action - [Tests] backport appveyor.yml - [Tests] add coverage for a malformed package.json - [Tests] only run `eclint` on intended files - [Tests] add coverage for absolute paths - [Tests] `invalid_main` fixture had an invalid "name" field - [Dev Deps] update `eslint`, `@ljharb/eslint-config`, `array.prototype.map`, `safe-publish-latest`, `tape` - [Dev Deps] update `eslint`, `@ljharb/eslint-config`, `aud`, `tape` v1.20.0 - [New] add `readPackage` and `readPackageSync` (#236) - [Deps] update `is-core-module` - [meta] do not publish github action workflow files - [meta] create SECURITY.md - [meta] do not fail when `aud` is running and deps are not present - [meta] fix indentation in lib/core.json - [Dev Deps] update `eslint`, `@ljharb/eslint-config`, `array.prototype.map`, `aud`, `tape` - [Tests] skip `npm ls` check on older nodes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #283.
Test results: