Source maps, fixes #2 #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use magic-string for source map generation. Magic-string can also handle string replacements but static-module already does that well with streams. This patch only uses the source map generation capabilities of magic-string.
4 tasks
yoshuawuyts
approved these changes
Feb 28, 2018
|
Just a note – I haven't got detailed benchmarks but my bundle time has gone up dramatically in recent browserify versions (as in, 3 seconds to 7 seconds) and I suspect it's because of this change and source map generation. |
|
Dang. Source mapping takes surprisingly little time on my machine but maybe I'm playing with too few transforms or files. Do you have a project you're seeing these numbers on that i could try out? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use magic-string for source map generation. Magic-string can also handle
string replacements but static-module already does that well with
streams. This patch only uses the source map generation capabilities of
magic-string.
If the source string contains a source mapping comment, the static-module
changes are merged into it, so the final source map points back to the
original source.
Source maps are opt in using the
sourceMap: trueoption.