-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error: Unexpected token #18
Comments
Hmm, envify may not support object rest spread syntax yet. |
envify uses Esprima which doesn't support |
I can try to take a look at this today! |
Took a few days to get to but I'm just working on getting all the tests to pass -- acorn is luckily very similar to esprima :) |
I spoke too soon! Variable assignments are a bit trickier to handle in acorn. Will try to wrap this up tonight |
Had you much luck 🍀 @toddself ? |
i had another shot just now and I think i got it to work: hughsk/envify#62 |
@goto-bus-stop can we get that merged? |
📦 2.5.2 |
Might be related to #14, but I'm getting more parsing errors when browserifying using tinyify. Using
tinyify@2.5.0
My target is the json1 OT library at SHA
8907bf44049003efa0e3c26146fd891524b91264
The error seems to be related to environment variable handling. If I change this line:
to
then browserify runs successfully. It crashes if I use
process.env.NODE_ENV === 'production'
.I'll have a deeper look when I have some more time if nobody else gets to it by then.
The text was updated successfully, but these errors were encountered: