Port to acorn-node for modern syntax support #62
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Amazing. 👏 |
|
Can this be merged? Ping @goto-bus-stop @hughsk |
|
Applied in https://github.com/browserify/envify |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch moves from esprima to acorn-node, which has support for many new JS syntax features. It aims to keep up parity with Node.js. For example, async functions and object rest spread now work.
I've mostly kept the old logic intact, comparing nodes with === doesn't work in acorn so I've added an
equalNodesfunction that I think covers all necessary bases.Note this does not add support for destructuring process.env yet (eg #58), it just prevents envify from erroring out on files that contain new syntax features.
Fixes browserify/tinyify#18