Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add troubleshooting information for silenced errors #351

Merged
merged 1 commit into from
May 16, 2018

Conversation

menzow
Copy link
Contributor

@menzow menzow commented Nov 17, 2017

There's been some issues and confusion (#350, #323, #266) about the change in behavior introduced by watchify when it is registered as browserify plugin.

Some people expect node to crash on errors, and are not aware of how Nodes event handling system works. Although this isn't a issue directly related to watchify, it might be helpful to have some guidance in the docs..

I've added a extra subsection to the troubleshooting docs. And I also updated the example snippet with a error handler.

Closes #350
Closes #323

@goto-bus-stop
Copy link
Member

makes sense to me. thanks!

@goto-bus-stop goto-bus-stop merged commit 1917270 into browserify:master May 16, 2018
@menzow
Copy link
Contributor Author

menzow commented May 28, 2018

Great to see this still getting into master. Thanks @goto-bus-stop

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants