Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JS: Fix swap button on test-page #388

Merged
merged 2 commits into from
Mar 24, 2022
Merged

JS: Fix swap button on test-page #388

merged 2 commits into from
Mar 24, 2022

Conversation

jerinphilip
Copy link
Contributor

@jerinphilip jerinphilip commented Mar 23, 2022 •
edited
Loading

#358 changed a text area to a div to show quality UI renders, causing the code that swapped content on click of the button to populate instead with undefined.

This change uses innerText on the output to populate input to fix the issue.

@jerinphilip
Copy link
Contributor Author

image

Swapped with button:
image

jelmervdl
jelmervdl approved these changes Mar 24, 2022
View reviewed changes
Copy link
Member

@jelmervdl jelmervdl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I thought I fixed that, but that was in one of my own branches. Oops! 😅

@jerinphilip jerinphilip merged commit 46882e7 into browsermt:main Mar 24, 2022
@jerinphilip jerinphilip deleted the swap-button-fix branch March 24, 2022 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jelmervdl jelmervdl jelmervdl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jerinphilip @jelmervdl