Skip to content
This repository has been archived by the owner on May 27, 2019. It is now read-only.

Support gopass mounts #77

Closed
adius opened this issue May 13, 2017 · 11 comments
Closed

Support gopass mounts #77

adius opened this issue May 13, 2017 · 11 comments

Comments

@adius
Copy link

adius commented May 13, 2017

We use gopass at work and therefore I've mounted the companies password store in my personal one.
This means there is google.com/john@doe.com and company-name/google.com/john@company-name.com
Those company entries however don't show up in browserpass.

@martinhoefling
Copy link

What would be the best way to implement this. the browserpass searches for the password store and then in it's subdirectories and does not use pass/gopass for this task. I could imagine to implement the Store interface with methods with shell out to gopass. Any other ideas?

@mjrider
Copy link

mjrider commented Aug 3, 2017

@martinhoefling vendoring the gopass code, and calling the subroutines directly instead of re-implementing the same wheel and/or using shell execution?

@maximbaz maximbaz changed the title Domains from mounts are not listed Support gopass mounts Sep 14, 2017
@maximbaz
Copy link
Member

Gopass mounts are not physical subdirectories in .password-store, otherwise they would have been discovered by browserpass. On the one hand, I like not reimplementing wheels, on the other hand the current code is not using pass since #6, so it is not as simple as just replacing pass with gopass everywhere in the code.

Since current code is handling fine one password-store, maybe yet another approach would be to make an option to define paths to multiple password stores somewhere in extension config, and reuse the same code as we have now?

@adius
Copy link
Author

adius commented Sep 22, 2017

👉 make an option to define paths to multiple password stores somewhere in extension config

@maximbaz
Copy link
Member

maximbaz commented Sep 27, 2017

This would be an awesome next addition to the project. I see this as a list of entries on the options page, with a checkbox next to each entry so that we can configure the list of password stores once, and toggle which ones are needed (such toggling functionality is requested in #98).

The options page was recently created in #95.

The primary challenge here I think is communicating from browser to host app this list of active password stores, and making sure the list doesn't go out of sync between the browser and the host app. Once this list is available in the host app, wrapping the existing code in a loop should not be big of a deal.

There is an interesting comment in #20, suggesting that a better way to connect to the host app might be to establish a single alive connection to the host app and never kill it. Such an always open connection could help maintain the synchronized list of password stores (and also solve the #20).

So... anyone up for a challenge? 🙂

@zsau
Copy link
Contributor

zsau commented Nov 15, 2017

My purposes would be served by a one-store-per-container model. Do others want to have multiple stores active at one time, or maybe the ability to switch between stores on-the-fly without using containers?

@maximbaz
Copy link
Member

I personally understood this ticket as specifically about many-to-one model, where there are multiple password stores (one personal and one for work), and people want to combine both of them and see credentials from both in the single browser/browserpass instance.

The gopass is a CLI tool that "virtually" combines many password stores in one, here it is asked about the same thing for browserpass.

@erayd
Copy link
Contributor

erayd commented Nov 15, 2017

I concur. I don't actually need this (one password store is fine for my purposes), however if I was using multiple stores, I would want them all active simultaneously.

Needing to manually switch stores depending on the login being used would be a significant and annoying bottleneck in the password-filling workflow.

@martinhoefling
Copy link

If you're interested in a browser plugin working with gopass, have a look at gopassbridge. The UI is heavily inspired from browserpass which I originally used with gopass before writing that extension.

@maximbaz
Copy link
Member

Hey guys, please share your thoughts on an idea to make this browser extension support gopass host.

@maximbaz
Copy link
Member

Implemented in PR #237, will release after a few days of testing myself. Early feedback is welcome.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

No branches or pull requests

6 participants